libicns: 0.8.1 -> unstable-2022-04-10

[reckenrode]

Description of changes

libicns hasn’t had a release in over a decade, but development has continued upstream. Updating removes the need for the openjp2 patch and includes fixes needed to build with newer versions of clang.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[reckenrode]

Result of nixpkgs-review pr 252255 run on aarch64-darwin 1

3 packages marked as broken and skipped:

• ares
• higan
• kotatogram-desktop

1 package failed to build:

• mikutter

9 packages built:

• bsnes-hd
• grandorgue
• kitty
• kitty.kitten
• kitty.shell_integration
• kitty.terminfo
• libicns
• netbeans
• rehex

[reckenrode]

Result of nixpkgs-review pr 252255 run on aarch64-linux 1

1 package failed to build:

• urbanterror

4 packages built:

• grandorgue
• libicns
• netbeans
• vcv-rack

[reckenrode]

Result of nixpkgs-review pr 252255 run on x86_64-darwin 1

2 packages marked as broken and skipped:

• ares
• higan

2 packages failed to build:

• kotatogram-desktop
• mikutter

9 packages built:

• bsnes-hd
• grandorgue
• kitty
• kitty.kitten
• kitty.shell_integration
• kitty.terminfo
• libicns
• netbeans
• rehex

[reckenrode]

Result of nixpkgs-review pr 252255 run on x86_64-linux 1

5 packages built:

• grandorgue
• libicns
• netbeans
• urbanterror
• vcv-rack

[reckenrode]

Regarding the failures:

• kotatogram-desktop and mikutter fail due to dependencies (tg_owt and ruby-glib respectively). tg_owt is missing a file (causing cmake to fail), and ruby-glib fails due to a compiler error (static declaration of 'g_bookmark_file_get_type' follows non-static declaration); and
• urbanterror is not supported on aarch64-linux.

[toonn]

LGTM