Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmedcon : proposals for nix systems without gnome #250800

Closed
wants to merge 5 commits into from
Closed

xmedcon : proposals for nix systems without gnome #250800

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
075e0bd
- Add wrapGAppsHook. Prevents crash issue 16285.
Aug 22, 2023
9959053
- Set project homepage to main url.
Aug 22, 2023
5c3aff0
- Include path to schemas within a shell.
Aug 22, 2023
6c3de70
- Add hicolor-icon-theme for missing icons.
Aug 22, 2023
c22e898
Merge branch 'NixOS:master' into master
enlf-dev Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pkgs/applications/science/medicine/xmedcon/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
, pkg-config
, libpng
, zlib
, wrapGAppsHook
, hicolor-icon-theme
}:

stdenv.mkDerivation rec {
Expand All @@ -24,11 +26,15 @@ stdenv.mkDerivation rec {
zlib
];

nativeBuildInputs = [ pkg-config ];
nativeBuildInputs = [ pkg-config wrapGAppsHook ];

shellHook = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we set shellHook anywhere in nixpkgs, and I don't think we patch in random icon themes either. These are usually picked up ambiently from the environment, so I'd skip that part.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this.

export XDG_DATA_DIRS="$GSETTINGS_SCHEMAS_PATH:${hicolor-icon-theme}/share"
'';

meta = with lib; {
description = "An open source toolkit for medical image conversion ";
homepage = "https://xmedcon.sourceforge.io/Main/HomePage";
homepage = "https://xmedcon.sourceforge.net/";
license = licenses.lgpl2Plus;
maintainers = with maintainers; [ arianvp flokli ];
platforms = platforms.darwin ++ platforms.linux;
Expand Down