input-remapper: 1.5.0 -> 2.0.1 #249777
input-remapper: 1.5.0 -> 2.0.1 #249777
Conversation
ofborg
bot
added
11.by: package-maintainer
LunNova
force-pushed
the
lunnova/input-remapper-2.x
branch
2 times, most recently
from
164feb2 to
4ea81cf
Compare
LunNova
changed the title
|
Result of 2 packages built:
|
This comment was marked as outdated.
This comment was marked as outdated.
LunNova
force-pushed
the
lunnova/input-remapper-2.x
branch
from
4ea81cf to
5d7710b
Compare
github-actions
bot
added
the
6.topic: nixos
|
@ofborg build input-remapper.tests input-remapper |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2822 |
|
I've been using this fix for my system for about a week without any major issues. Anything that I can do/test to help this get merged? |
|
I'm happy with it, just needs approved and merged! |
pkgs/top-level/all-packages.nix
Outdated
| #python310 as pydbus does not build on 3.11 | ||
| input-remapper = python310Packages.callPackage ../tools/inputmethods/input-remapper { }; |
There was a problem hiding this comment.
pydbus supports python3.11 as of #263669
| #python310 as pydbus does not build on 3.11 | |
| input-remapper = python310Packages.callPackage ../tools/inputmethods/input-remapper { }; | |
| input-remapper = python3Packages.callPackage ../tools/inputmethods/input-remapper { }; |
There was a problem hiding this comment.
reverting that might have made the nixos test hang or this laptop i tested on is just way too slow, asked ofborg to run them
There was a problem hiding this comment.
looks like it passed on ofborg
LunNova
force-pushed
the
lunnova/input-remapper-2.x
branch
from
5d7710b to
a95b6e1
Compare
|
@ofborg build input-remapper.tests input-remapper |
|
@SuperSandro2000 can you rereview? |
Corrected data path replacement Updated test for new UI https://github.com/sezanzeb/input-remapper/releases/tag/2.0.0 https://github.com/sezanzeb/input-remapper/releases/tag/2.0.1
LunNova
force-pushed
the
lunnova/input-remapper-2.x
branch
from
9552fd4 to
1356903
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2997 |
| }; | ||
|
|
||
| postPatch = '' | ||
| # fix FHS paths | ||
| substituteInPlace inputremapper/configs/data.py \ | ||
| --replace "/usr/share/input-remapper" "$out/usr/share/input-remapper" | ||
| --replace "/usr/share" "$out/usr/share" |
There was a problem hiding this comment.
Why is it $out/usr/share instead of $out/share?
Just notice this when resolving merge conflicts for #271387.
There was a problem hiding this comment.
Good question, the default path in nixpkgs would be just $out/share
There was a problem hiding this comment.
The setup.py in the input-remapper repo ends up placing data there. Could change it, means patching more places.
*these are absolute paths in setup.py, the way nixpkgs buildPythonApplication builds these results in them going under $out rather than the build failing.
Corrected data path replacement
and moved to python 3.10 as pydbusdoesn't support 3.11
https://github.com/sezanzeb/input-remapper/releases/tag/2.0.0
https://github.com/sezanzeb/input-remapper/releases/tag/2.0.1
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)