texlive: fix tlmgr, tlshell, licenses #247798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: TeX
|
@GrahamcOfBorg build tests.texlive |
figsoda
added
12.approvals: 1
12 tasks
xworld21
changed the title
xworld21
force-pushed
the
texlive-tlmgr-tlshell
branch
from
8c8565c to
447fd50
Compare
|
@GrahamcOfBorg build tests.texlive @veprbl could you please merge, assuming the tests pass? |
apfelkuchen6
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
LGTM.
The artiistic1 and gpl1Only licenses appear to have been (incorrectly) pulled in by biber:
nix-repl> :p biber.meta.license
[ { deprecated = false; free = true; fullName = "Artistic License 1.0"; redistributable = true; shortName = "artistic1"; spdxId = "Artistic-1.0"; url = "https://spdx.org/licenses/Artistic-1.0.html"; } { deprecated = false; free = true; fullName = "GNU General Public License v1.0 or later"; redistributable = true; shortName = "gpl1Plus"; spdxId = "GPL-1.0-or-later"; url = "https://spdx.org/licenses/GPL-1.0-or-later.html"; } ]
As far as I can tell, the correct license is Artistic2 as indicated in tlpdb.
12 tasks
12 tasks
|
@xworld21 Sorry, this slipped by. Could you, please, rebase? |
23 tasks
texlive.infra includes tlmgr and related TeXLive::* perl modules which are licensed under GPL2 or later. It also brings the GPL2 bin.core.
xworld21
force-pushed
the
texlive-tlmgr-tlshell
branch
from
447fd50 to
b32c641
Compare
|
@GrahamcOfBorg build tests.texlive.licenses just in case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Minimal changes to make tlmgr and tlshell work when called with
--usermode. Among thetexlive.infrachanges, it also adds the GPL2 and GPL2+ licenses for respectivebin.core(which is included in all schemes) andtlmgritself (whose license is not flagged in texlive.tlpdb).This is hacky in that the shipped texlive.tlpdb does not contain the installed packages, so tlmgr/tlshell do not know which packages are already installed in the system tree. Generating the correct texlive.tlpdb seems tricky anyway.
Note: this includes a fix for the scheme licenses as reported in #247738 (review) and it is written on top of #247738. @apfelkuchen6 could you please double check why we had
artistic1andgpl1Only? I don't find them intlpdb.nixnor inbin.nixso I am a little worried now at how they got in.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)