Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow-cpp: fix build with clang 15+ #243530

Closed
wants to merge 1 commit into from
Closed

arrow-cpp: fix build with clang 15+ #243530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20153,7 +20153,11 @@ with pkgs;

arrayfire = darwin.apple_sdk_11_0.callPackage ../development/libraries/arrayfire { };

arrow-cpp = callPackage ../development/libraries/arrow-cpp { };
arrow-cpp = callPackage ../development/libraries/arrow-cpp {
# arrow-cpp requires Boost 1.81 or newer when building with clang 15+.
boost = if stdenv.cc.isClang && lib.versionAtLeast (lib.getVersion stdenv.cc) "15"
then boost18x else boost;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dropped boost18x in #243286.

Suggested change
then boost18x else boost;
then boost181 else boost;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also looks like #240604 will bump boost to 1.81, which is what arrow-cpp needs with clang 15+. In that case, this PR is unnecessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one got merged

};

arrow-glib = callPackage ../development/libraries/arrow-glib { };

Expand Down