Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: drop PHP 8.0 #239049

Merged
merged 2 commits into from
Jun 22, 2023
Merged

php: drop PHP 8.0 #239049

merged 2 commits into from
Jun 22, 2023

Conversation

LeSuisse
Copy link
Contributor

Description of changes

This change drops PHP 8.0. n98-magerun is marked as broken until it can support PHP 8.1+.

Closes #224505

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

LeSuisse added 2 commits June 21, 2023 21:57
@LeSuisse
n98-magerun: mark as broken
62c0b2b 
n98-magerun is not yet compatible with PHP 8.1.
@LeSuisse
php: drop PHP 8.0
84c0cb1 
Closes NixOS#224505
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 21, 2023
@ofborg ofborg bot requested a review from drupol June 21, 2023 21:37
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 21, 2023
@drupol
Copy link
Contributor

drupol commented Jun 22, 2023

Ready to be merged, please proceed.

@etu etu merged commit da7b79c into NixOS:master Jun 22, 2023
@LeSuisse LeSuisse deleted the php80-removal branch June 22, 2023 07:02
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
e18f0bf 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
95f7a94 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
9b93846 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
2665cd9 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
37f2cc8 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
a124a14 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
252c278 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
a69a928 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
c44761f 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
4287393 
This is a consequence of PR NixOS/nixpkgs#239049
drupol added a commit to fossar/nix-phps that referenced this pull request Jun 26, 2023
@drupol
php80: init at 8.0.29
84ba9b5 
This is a consequence of PR NixOS/nixpkgs#239049
@drupol drupol mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

@drupol drupol drupol approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@aanderse aanderse Awaiting requested review from aanderse

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.0 removal
3 participants
@LeSuisse @drupol @etu