Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arcanist: 20220517 -> 20230401, switch to PHP 8.1 #232272

Merged
merged 1 commit into from
Jun 3, 2023
Merged

arcanist: 20220517 -> 20230401, switch to PHP 8.1 #232272

merged 1 commit into from
Jun 3, 2023

Conversation

LeSuisse
Copy link
Contributor

Description of changes

It seems that most issues related to PHP 8.1 have been fixed according to the issue tracker: https://secure.phabricator.com/T13588

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • arcanist

@LeSuisse
arcanist: 20220517 -> 20230401, switch to PHP 8.1
8556a98 
It seems that most issues related to PHP 8.1 have been fixed according
to the issue tracker.
@LeSuisse LeSuisse mentioned this pull request May 16, 2023
Closed
8 tasks
@ofborg ofborg bot requested a review from thoughtpolice May 16, 2023 18:12
@LeSuisse LeSuisse added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 29, 2023
@Patryk27
Copy link
Member

Patryk27 commented Jun 3, 2023

I can confirm this works on aarch64-darwin as well.

@LeSuisse
Copy link
Contributor Author

LeSuisse commented Jun 3, 2023

Thanks for the confirmation, I'm merging this 🎉

@LeSuisse LeSuisse added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jun 3, 2023
@LeSuisse LeSuisse merged commit d4ca64c into NixOS:master Jun 3, 2023
@Patryk27
Copy link
Member

Patryk27 commented Jun 3, 2023 •
edited
Loading

Uh, I might've been too quick - it looks like arc diff can sometimes fail 😅

In my case I've got:

Launching editor "vim"...
Supply commit message for uncommitted changes, then save and exit.
Launching editor "vim"...
Provide the details for a new revision, then save and exit.
Linting...
 Exception 
Some linters failed:
    - RuntimeException: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
(Run with `--trace` for a full exception trace.)

It looks like the newest-newest version of Arcanist fixes that (they've got a new commit four days ago) 😄

@drupol
Copy link
Contributor

drupol commented Jun 3, 2023

Submit a PR, we'll take care of it.

@Patryk27
Copy link
Member

Patryk27 commented Jun 3, 2023 •
edited
Loading

kk, lemme just double-check that version works and will do

@LeSuisse LeSuisse deleted the arcanist-20230401 branch June 3, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeSuisse @Patryk27 @drupol