Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensearch: 2.6.0 -> 2.7.0 #230115

Merged
merged 1 commit into from
May 13, 2023
Merged

opensearch: 2.6.0 -> 2.7.0 #230115

merged 1 commit into from
May 13, 2023

Conversation

shyim
Copy link
Member

@shyim shyim commented May 5, 2023

Description of changes

Updates the Opensearch package to the latest version of the 2.7.0.

Removed our patch as the latest version contains the patch opensearch-project/OpenSearch#6956

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented May 5, 2023

I'm a little confused how this package downloads the -linux-x64.tar.gz version and then claims platforms.unix support. There's at least one native .so in that tarball (libopensearchknn_*.so)

@shyim
Copy link
Member Author

shyim commented May 6, 2023

By just changing the java to our own it works in all platforms, except the ML features which requires that .so files. 😅

@risicle
Copy link
Contributor

risicle commented May 6, 2023

Could you add to meta

sourceProvenance = with lib.sourceTypes; [
  binaryBytecode
  binaryNativeCode
];

then please.

@shyim shyim force-pushed the update-opensearch branch from cb0f907 to 4133292 Compare May 13, 2023 11:08
@risicle
Copy link
Contributor

risicle commented May 13, 2023

Sorry, I should have made it clearer - the sourceProvenance attribute needs to be added to the meta section.

@shyim shyim force-pushed the update-opensearch branch from 4133292 to 5ebd956 Compare May 13, 2023 19:38
@shyim
Copy link
Member Author

shyim commented May 13, 2023

All good I was brain dead :). Fixed :)

@risicle risicle merged commit 4a77ca9 into NixOS:master May 13, 2023
@shyim shyim deleted the update-opensearch branch May 13, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants