Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tensorflow: 2.11.0 -> 2.11.1 #224846

Merged
merged 1 commit into from
Apr 15, 2023
Merged

python3Packages.tensorflow: 2.11.0 -> 2.11.1 #224846

merged 1 commit into from
Apr 15, 2023

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 5, 2023 •
edited
Loading

Description of changes

2.12.0 is out, but that didn't immediately work for me and 2.11.1 appears to address the same CVEs.

https://github.com/tensorflow/tensorflow/releases/tag/v2.11.1

Seeking volunteer(s) to generate the deps hashes for aarch64-linux and aarch64-darwin, otherwise I'll get ofborg to do it and everyone will hate me for making ofborg build tensorflow...

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 5, 2023
@ofborg ofborg bot requested review from abbradar and cdepillabout April 5, 2023 18:11
@SomeoneSerge
Copy link
Contributor

SomeoneSerge commented Apr 5, 2023 •
edited
Loading

Seeking volunteer(s) to generate the deps hashes for aarch64-linux and aarch64-darwin

On that note, there were some experiments around forcing Bazel to fetch dependencies for all platforms at once in aaf0d0a. This way there should be just one hash, which can be computed on any platform. I'm still unclear on whether that is actually already working, and I don't know if the same trick could be applied to tensorflow

(and my review will come in later, sorry 🙃 )

@risicle risicle mentioned this pull request Apr 6, 2023
Closed
1 task
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tensorflow-unstable-not-installing-after-update/27041/2

@SomeoneSerge SomeoneSerge mentioned this pull request Apr 6, 2023
Closed
1 task
@risicle risicle force-pushed the ris-tensorflow-2.11.1 branch from 831682d to 7e93ac1 Compare April 6, 2023 11:44
@risicle
Copy link
Contributor Author

risicle commented Apr 6, 2023

Got the aarch64-darwin hash now

@mweinelt
Copy link
Member

mweinelt commented Apr 6, 2023

Seeking volunteer(s) to generate the deps hashes for aarch64-linux and aarch64-darwin, otherwise I'll get ofborg to do it and everyone will hate me for making ofborg build tensorflow...

aarch64-darwin sha256-qZvqXi6pvIrZpZdR4BcbOh2C/A4ZHJgXgFINhVJmmcs=
aarch64-linux sha256-g6JUZQQalCTSjvAarkI7+gq13cPhFg/O9LPQDGNvrII=

@risicle risicle force-pushed the ris-tensorflow-2.11.1 branch from 7e93ac1 to ffa8fc7 Compare April 6, 2023 12:09
@risicle risicle marked this pull request as ready for review April 6, 2023 12:09
@SomeoneSerge
Copy link
Contributor

Needs a rebase before nixpkgs-review can take off

@risicle risicle force-pushed the ris-tensorflow-2.11.1 branch from ffa8fc7 to 8ef8786 Compare April 6, 2023 12:57
@risicle
Copy link
Contributor Author

risicle commented Apr 6, 2023

Hmm hopefully #224917 doesn't cause us to have to recalculate all the hashes.

@SomeoneSerge SomeoneSerge mentioned this pull request Apr 10, 2023
Closed
@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 13, 2023
@mweinelt
Copy link
Member

Builds fine on x86_64-linux and works for tts.

@SomeoneSerge
Copy link
Contributor

Just for the record: we're currently blocked by the merge conflicts

@risicle
Copy link
Contributor Author

risicle commented Apr 15, 2023

That's because this got bumped past in #225174

@risicle risicle closed this Apr 15, 2023
@SomeoneSerge
Copy link
Contributor

That one only updates the -bin?

@mweinelt mweinelt reopened this Apr 15, 2023
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 15, 2023
@risicle
Copy link
Contributor Author

risicle commented Apr 15, 2023

Damn I shouldn't have combined the two in the same PR. Just confusing. Stand by...

@risicle risicle force-pushed the ris-tensorflow-2.11.1 branch from 8ef8786 to 0efaf98 Compare April 15, 2023 19:27
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 15, 2023
@mweinelt mweinelt changed the title python3Packages.tensorflow(-bin): 2.11.0 -> 2.11.1 python3Packages.tensorflow: 2.11.0 -> 2.11.1 Apr 15, 2023
@mweinelt mweinelt merged commit 8f8bb3b into NixOS:master Apr 15, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tensorflow-unstable-not-installing-after-update/27041/7

@dotlambda
Copy link
Member

dotlambda commented Apr 16, 2023 •
edited
Loading

Don't forget that this has to be backported.

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 16, 2023
@mweinelt
Copy link
Member

1.10.1 on 22.11 :/

@risicle
Copy link
Contributor Author

risicle commented Apr 16, 2023

#224988

@SomeoneSerge SomeoneSerge mentioned this pull request Apr 21, 2023
Closed
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneSerge SomeoneSerge Awaiting requested review from SomeoneSerge

@dotlambda dotlambda Awaiting requested review from dotlambda

@abbradar abbradar Awaiting requested review from abbradar

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python 8.has: package (new) This PR adds a new package 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@risicle @SomeoneSerge @nixos-discourse @mweinelt @dotlambda @vcunat