-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongodb-3_4, mongodb-3_6: drop #207382
mongodb-3_4, mongodb-3_6: drop #207382
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1620 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Just for anyone dropping by: This harsh update from version 3.4 to 6.0 breaks For others who noticed the database getting corrupted:
I'm not sure whether thes gradual procedure is necessary, but at least it works. EDIT: |
Otherwise unifi might break on a next big update just like NixOS#207382 (comment) Also this requires an update of the unifi package. With the LTS version, newer mongodb versions aren't supported. The current supported version of unifi 7 is mongodb 3.6 acording to https://community.ui.com/releases/UniFi-Network-Application-7-0-20/3e4a4099-c063-42f6-8e21-5fb2c99fcea9 which isn't even supplied by nixpkgs anymore. mongodb-4_2 isn't officially supported, but works. Signed-off-by: Florian Brandes <[email protected]>
This needs a release note and upgrade instructions if needed |
What would be the best way to tackle this? I just feel a release note isn't enough, since every user who updates to |
Perhaps by specifying in the release note that MongoDB upgrades must be done (and progressively, following the official instruction |
@wegank and @mweinelt Should we link it in the release notes? Include it in NixOS? I'm not sure what the best approach would be. I also though about an automatic migration in the NixOS service, but I'm afraid this wouldn't be robust. |
Awesome, thank you. I do not advise for automatic migrations as you remarked it would not be robust. @riotbib, the release editor for 23.05 can help you find a way to format those instructions properly in the release notes. |
This bit me today, after reading the release notes and seeing no mention of breaking changes :( |
Description of changes
#203814 seems to be stalled, so let's try again.
The original PR drops boost160 while keeping boost159. I think it would be better to drop them both after #207373.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes