Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxd: 5.6 -> 5.7 #197256

Merged
merged 1 commit into from
Oct 23, 2022
Merged

lxd: 5.6 -> 5.7 #197256

merged 1 commit into from
Oct 23, 2022

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 22, 2022

Description of changes

https://github.com/lxc/lxd/releases/tag/lxd-5.7

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 22, 2022
@marsam
Copy link
Contributor Author

marsam commented Oct 23, 2022

@GrahamcOfBorg eval

@zowoq
Copy link
Contributor

zowoq commented Oct 23, 2022

lxd test failure should have been fixed by 15c32d0

@ofborg eval

@marsam
Copy link
Contributor Author

marsam commented Oct 23, 2022

Thanks a lot for fixing the tests

ivan
ivan approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not encounter issues on x86_64 NixOS master, testing the Debian container that I run in LXD. I didn't see any unexpected log messages for lxd or inside the container.

@marsam marsam merged commit ca39d73 into NixOS:master Oct 23, 2022
@marsam marsam deleted the update-lxd branch October 23, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marsam @zowoq @ivan