Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More GNOME updates #195900

Merged
merged 3 commits into from
Oct 15, 2022
Merged

More GNOME updates #195900

merged 3 commits into from
Oct 15, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Oct 14, 2022 •
edited
Loading

Things done

Follow up to #182618.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 15, 2022
@jtojnar jtojnar mentioned this pull request Oct 15, 2022
Merged
13 tasks
amaxine
amaxine approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@amaxine amaxine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs look good (basically just a translation update for gcr/seahorse, minus some minor rewrites), diff looks good. Your commit message for gupnp-tools repeats in the body.

@jtojnar
Copy link
Member Author

jtojnar commented Oct 15, 2022

Ugh, the git bug again.

@jtojnar
Copy link
Member Author

jtojnar commented Oct 15, 2022

Looks like there are still some more packages not covered by an updatescript: https://repology.org/projects/?maintainer=jtojnar%40gmail.com&outdated=1&inrepo=nix_unstable

@ofborg ofborg bot requested a review from amaxine October 15, 2022 10:13
@jtojnar jtojnar merged commit a36ceb8 into NixOS:master Oct 15, 2022
@jtojnar jtojnar deleted the gnome branch October 15, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@dasj19 dasj19 Awaiting requested review from dasj19

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@hedning hedning Awaiting requested review from hedning

@amaxine amaxine Awaiting requested review from amaxine

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtojnar @amaxine