Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.bip_utils: 2.2.1 -> 2.7.0 #194954

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

StarGate01
Copy link
Member

@StarGate01 StarGate01 commented Oct 7, 2022

Description of changes

This PR continues / supersedes the PR #181247 by @onny , it fixes and updates the bip_utils Python package.

The previous blocker PyO3/pyo3#5 has since been resolved in 0.11.0, however the dependency https://github.com/polkascan/py-sr25519-bindings did not yet update to the fixed version >=0.11.0 of PyO3. Because of this, the Cargo dependency file is patched here based on a pending PR Patched upstream. This small upgrade compiles and runs without issues, upgrading to PyO3 0.17.2 (the most recent one) would break py-sr25519-bindings .

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Oct 7, 2022

https://github.com/polkascan/py-sr25519-bindings did not yet update to the fixed version >=0.11.0 of PyO3.

Why don't you send a pull request to py-sr25519-bindings and fetch patch from GitHub rather than providing it in nixpkgs tree?

@StarGate01
Copy link
Member Author

@prusnak

Why don't you send a pull request to py-sr25519-bindings and fetch patch from GitHub rather than providing it in nixpkgs tree?

Thank you for the suggestion, I opened and implemented polkascan/py-sr25519-bindings#10 .

@prusnak
Copy link
Member

prusnak commented Oct 7, 2022

Package sr25519-bindings does not build on darwin because of missing iconv.

Please add libiconv conditionally to buildInputs : buildInputs = lib.optionals stdenv.isDarwin [ libiconv ];

@StarGate01
Copy link
Member Author

Thanks, it now appears to build correctly on darwin.

crcmod
ed25519-blake2b
py-sr25519-bindings
pycryptodome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were we getting away without half of these before? The package's requirements don't appear to have changed a lot since 2.5.1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure myself, but found the packages to be required at runtime when actually trying to use the library. I suspect they might have slipped though earlier.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Oct 11, 2022
@StarGate01
Copy link
Member Author

StarGate01 commented Oct 11, 2022

@SuperSandro2000 @risicle Thanks for your suggestions, I have implemented the proposed changes. The tests of py-sr25519-bindings required adding a new package py-bip39-bindings.

@onny
Copy link
Contributor

onny commented Oct 11, 2022

Please merge commits if possible

@SuperSandro2000 SuperSandro2000 merged commit 33bc904 into NixOS:master Oct 11, 2022
@StarGate01 StarGate01 deleted the bip_utils_update branch October 26, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants