-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.bip_utils: 2.2.1 -> 2.7.0 #194954
Conversation
Why don't you send a pull request to py-sr25519-bindings and fetch patch from GitHub rather than providing it in nixpkgs tree? |
3355f18
to
ecccb83
Compare
Thank you for the suggestion, I opened and implemented polkascan/py-sr25519-bindings#10 . |
ecccb83
to
57c6a15
Compare
Package Please add libiconv conditionally to buildInputs : |
57c6a15
to
ad9fe8f
Compare
Thanks, it now appears to build correctly on darwin. |
crcmod | ||
ed25519-blake2b | ||
py-sr25519-bindings | ||
pycryptodome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How were we getting away without half of these before? The package's requirements don't appear to have changed a lot since 2.5.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure myself, but found the packages to be required at runtime when actually trying to use the library. I suspect they might have slipped though earlier.
pkgs/development/python-modules/py-sr25519-bindings/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/py-sr25519-bindings/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/py-sr25519-bindings/default.nix
Outdated
Show resolved
Hide resolved
ad9fe8f
to
3a6c579
Compare
@SuperSandro2000 @risicle Thanks for your suggestions, I have implemented the proposed changes. The tests of |
Please merge commits if possible |
3a6c579
to
50fe5f8
Compare
50fe5f8
to
efcbc9d
Compare
Description of changes
This PR continues / supersedes the PR #181247 by @onny , it fixes and updates the
bip_utils
Python package.The previous blocker PyO3/pyo3#5 has since been resolved in 0.11.0,
however the dependency https://github.com/polkascan/py-sr25519-bindings did not yet update to the fixed version >=0.11.0 of PyO3. Because of this, the Cargo dependency file is patched here based on a pending PRPatched upstream. This small upgrade compiles and runs without issues, upgrading to PyO3 0.17.2 (the most recent one) would break py-sr25519-bindings .Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes