-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hex: init at 0.4.2 #190813
Merged
Merged
hex: init at 0.4.2 #190813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newAM
approved these changes
Sep 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed points
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package build on x86_64-linux
- executables tested on x86_64-linux
-
meta.description
is set and fits guidelines -
meta.license
fits upstream license -
meta.platforms
is set -
meta.maintainers
is set - build time only dependencies are declared in
nativeBuildInputs
- source is fetched using the appropriate function
- the list of
phases
is not overridden - when a phase (like
installPhase
) is overridden it starts withrunHook preInstall
and ends withrunHook postInstall
. - patches that are remotely available are fetched with
fetchpatch
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Sep 11, 2022
newAM
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Sep 11, 2022
azahi
reviewed
Sep 11, 2022
IvarWithoutBones
force-pushed
the
init-hex
branch
from
September 11, 2022 20:48
4611e02
to
cb62326
Compare
Result of 1 package built:
|
azahi
approved these changes
Sep 11, 2022
bobby285271
added
12.approvals: 2
This PR was reviewed and approved by two reputable people
and removed
12.approvals: 1
This PR was reviewed and approved by one reputable person
labels
Sep 11, 2022
Result of 1 package built:
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12.approvals: 2
This PR was reviewed and approved by two reputable people
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds hex, an futuristic take on hexdump, made in Rust.
Fixes #190768
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes