Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nicotine-plus: 3.2.4 -> 3.2.6 #190262

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Sep 8, 2022

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for nicotine-plus is: "A graphical client for the SoulSeek peer-to-peer system"

meta.homepage for nicotine-plus is: "https://www.nicotine-plus.org"

meta.changelog for nicotine-plus is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 3.2.5 with grep in /nix/store/g187vbdj4ps20i0v4f8dizsh37c86769-nicotine-plus-3.2.5
  • found 3.2.5 in filename of file in /nix/store/g187vbdj4ps20i0v4f8dizsh37c86769-nicotine-plus-3.2.5

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
nicotine-plus
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/g187vbdj4ps20i0v4f8dizsh37c86769-nicotine-plus-3.2.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A nicotine-plus https://github.com/r-ryantm/nixpkgs/archive/e94d86a1a1c77f3a94871e7f22fe55feaecd2f2b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/g187vbdj4ps20i0v4f8dizsh37c86769-nicotine-plus-3.2.5
ls -la /nix/store/g187vbdj4ps20i0v4f8dizsh37c86769-nicotine-plus-3.2.5/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • nicotine-plus

Maintainer pings

cc @ehmry @klntsky for testing.

@ghost
Copy link

ghost commented Sep 28, 2022

Does this fix the Cannot find GTK 3, please install it warning?

@r-ryantm r-ryantm changed the title nicotine-plus: 3.2.4 -> 3.2.5 nicotine-plus: 3.2.4 -> 3.2.6 Oct 21, 2022
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for nicotine-plus is: "A graphical client for the SoulSeek peer-to-peer system"

meta.homepage for nicotine-plus is: "https://www.nicotine-plus.org"

meta.changelog for nicotine-plus is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 3.2.6 with grep in /nix/store/f7va34hplga27llq143v8wymsmiz6c16-nicotine-plus-3.2.6
  • found 3.2.6 in filename of file in /nix/store/f7va34hplga27llq143v8wymsmiz6c16-nicotine-plus-3.2.6

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
nicotine-plus
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/f7va34hplga27llq143v8wymsmiz6c16-nicotine-plus-3.2.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A nicotine-plus https://github.com/r-ryantm/nixpkgs/archive/043ada923e786546a0b18f21e7fd5cd0694fd774.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/f7va34hplga27llq143v8wymsmiz6c16-nicotine-plus-3.2.6
ls -la /nix/store/f7va34hplga27llq143v8wymsmiz6c16-nicotine-plus-3.2.6/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • nicotine-plus

Maintainer pings

cc @ehmry @klntsky for testing.

@r-ryantm r-ryantm force-pushed the auto-update/nicotine-plus branch from e94d86a to 043ada9 Compare October 21, 2022 15:04
@ehmry
Copy link
Contributor

ehmry commented Oct 22, 2022

Does this fix the Cannot find GTK 3, please install it warning?

I didn't fix it for me.

@ehmry
Copy link
Contributor

ehmry commented Oct 22, 2022

From what I can tell some stupid initialization error is coming up out of GTK and Nicotine catches it and prints the string "Cannot find GTK 3, please install it". What is happening here is something is breaking and the Python developer is blaming the user and taking no responsibility.

@mathiascode
Copy link

From what I can tell some stupid initialization error is coming up out of GTK and Nicotine catches it and prints the string "Cannot find GTK 3, please install it". What is happening here is something is breaking and the Python developer is blaming the user and taking no responsibility.

These are the possible reasons PyGObject provides: https://github.com/GNOME/pygobject/blob/4b421597d1885c725cbcdd44c4d04277454bee85/gi/__init__.py#L114-L130

Perhaps this is issue #56943? The solution is mentioned here: #56943 (comment)

@Artturin
Copy link
Member

gtk issue fixed by #200906

@Artturin Artturin merged commit 7222453 into NixOS:master Nov 12, 2022
@r-ryantm r-ryantm deleted the auto-update/nicotine-plus branch November 12, 2022 21:04
@slook
Copy link

slook commented Dec 15, 2022

User reports nicotine-plus fail at start #206303

cc @Artturin @ehmry @klntsky Thank you kindly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants