Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.orjson: 3.7.8 -> 3.7.12 #186580

Merged
merged 1 commit into from
Aug 17, 2022
Merged

python310Packages.orjson: 3.7.8 -> 3.7.12 #186580

merged 1 commit into from
Aug 17, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 14, 2022 •
edited
Loading

This update fixes tests that were broken with the update to version 2022b of tzdata.

https://github.com/ijl/orjson/blob/master/CHANGELOG.md#3712---2022-08-14

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni requested review from FRidh and jonringer as code owners August 14, 2022 07:06
@ofborg ofborg bot requested a review from misuzu August 14, 2022 08:35
misuzu
misuzu approved these changes Aug 14, 2022
View reviewed changes
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjni
python310Packages.orjson: 3.7.8 -> 3.7.12
b2db835 
This update fixes tests that were broken with the update to version
2022b of tzdata.

https://github.com/ijl/orjson/blob/master/CHANGELOG.md#3712---2022-08-14
@tjni tjni changed the title python310Packages.orjson: disable two tzdata tests python310Packages.orjson: 3.7.8 -> 3.7.12 Aug 14, 2022
@tjni
Copy link
Contributor Author

tjni commented Aug 14, 2022

The upstream has pushed a fix, and I have updated this PR to update to the latest version.

@tjni tjni requested a review from misuzu August 14, 2022 16:49
@tjni tjni changed the base branch from staging to staging-next August 17, 2022 04:45
@tjni tjni mentioned this pull request Aug 17, 2022
Merged
@mweinelt mweinelt self-assigned this Aug 17, 2022
@mweinelt mweinelt merged commit 3186958 into NixOS:staging-next Aug 17, 2022
@tjni tjni deleted the orjson-tzdata branch August 17, 2022 22:14
vcunat added a commit that referenced this pull request Aug 22, 2022
@vcunat
python3Packages.orjson: skip a problematic test
6542027 
For nixpkgs master we updated instead in PR #186580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misuzu misuzu misuzu approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

@mweinelt mweinelt

Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjni @misuzu @mweinelt