Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deltachat-desktop: 1.30.1 -> 1.32.0 #185813

Closed
wants to merge 1 commit into from

Conversation

dotlambda
Copy link
Member

Description of changes

https://github.com/deltachat/deltachat-desktop/blob/v1.32.0/CHANGELOG.md

I can't use the correct version of libdeltachat because of deltachat/deltachat-core-rust#3548.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@rapenne-s
Copy link
Member

with this change on top, latest version 1.32.1 builds and runs fine

diff --git a/pkgs/applications/networking/instant-messengers/deltachat-desktop/default.nix b/pkgs/applications/networking/instant-messengers/deltachat-desktop/default.nix
index 7266ebde10f..391455b4b9b 100644
--- a/pkgs/applications/networking/instant-messengers/deltachat-desktop/default.nix
+++ b/pkgs/applications/networking/instant-messengers/deltachat-desktop/default.nix
@@ -50,13 +50,13 @@ let
   };
 in nodePackages.deltachat-desktop.override rec {
   pname = "deltachat-desktop";
-  version = "1.32.0";
+  version = "1.32.1";
 
   src = fetchFromGitHub {
     owner = "deltachat";
     repo = "deltachat-desktop";
     rev = "v${version}";
-    hash = "sha256-5eau6CLgze13rc1+fhNgdy/NEbEHBKf5/xd5K+zb4Co=";
+    hash = "sha256-DklrTMnubVSkD1wfJzPRqWsVZy65kG7EuvRVRYcCUAI=";
   };
 
   nativeBuildInputs = [

I tried to port it without the fix, and can't get it to work...

@dotlambda
Copy link
Member Author

dotlambda commented Oct 21, 2022

@rapenne-s But libdeltachat 1.91.0 still doesn't work.

@dotlambda
Copy link
Member Author

@winterqt Do you still have the code that uses the recently merged #189539 for this update?

@dotlambda
Copy link
Member Author

superseded by #200981

@dotlambda dotlambda closed this Nov 13, 2022
@dotlambda dotlambda deleted the deltachat-desktop-1.32.0 branch November 13, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants