Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops: 1.23.1 -> 1.23.2 #174165

Merged
merged 1 commit into from
May 24, 2022
Merged

kops: 1.23.1 -> 1.23.2 #174165

merged 1 commit into from
May 24, 2022

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented May 23, 2022

Description of changes

Update to the latest patch version and fix the 22.05 release notes, which still mentioned 1.22.4 as the default.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation labels May 23, 2022
@yurrriq
Copy link
Member Author

yurrriq commented May 23, 2022 •
edited
Loading

We'll want to ensure this is included in the 22.05 release (#165792). cc @NixOS/nixos-release-managers

@yurrriq yurrriq marked this pull request as ready for review May 23, 2022 18:59
@yurrriq yurrriq requested review from dasJ, jonringer, Mic92 and tomberek May 23, 2022 19:02
@dasJ
Copy link
Member

dasJ commented May 23, 2022

@GrahamcOfBorg eval

@ofborg ofborg bot requested review from zimbatm and offlinehacker May 23, 2022 19:20
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 23, 2022
@dasJ
Copy link
Member

dasJ commented May 23, 2022

22.05 is already branched, so I'll add the backport label instead.

@dasJ
Copy link
Member

dasJ commented May 23, 2022

Also I'm really sorry but you'll have to rebase to the current master because I broke the manual (but I fixed it by now)

@Mic92
Copy link
Member

Mic92 commented May 23, 2022

@GrahamcOfBorg eval

@Mic92
Copy link
Member

Mic92 commented May 23, 2022

Just re-running the failing build is enough.

@yurrriq
kops: 1.23.1 -> 1.23.2
2a39386 
Also update 22.05 release notes, which still mentioned 1.22.4 as the default.
@yurrriq
Copy link
Member Author

yurrriq commented May 23, 2022

Rebased anyway, for good measure. Thanks, y'all.

@zimbatm zimbatm merged commit 3798f3c into NixOS:master May 24, 2022
@github-actions github-actions bot mentioned this pull request May 24, 2022
Closed
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #174269 for release-22.05.

@yurrriq yurrriq deleted the kops-1.23.2 branch June 8, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ Awaiting requested review from dasJ

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

@tomberek tomberek Awaiting requested review from tomberek

@zimbatm zimbatm Awaiting requested review from zimbatm

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yurrriq @dasJ @Mic92 @zimbatm