-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modemmanager: 1.18.6 -> 1.18.10 #172742
modemmanager: 1.18.6 -> 1.18.10 #172742
Conversation
Hmm, what does this mean for us:
|
I somehow blanked on that when reading the changelog. As I understand, if we don't expose it it's just a feature no one can use - not replacing any existing functionality. I suppose what we need to do here is give users a way to provide scripts via the module. |
Looks like it is a no-op when the directory does not exist: |
0d92a9d
to
9350ec8
Compare
I took the liberty of rebasing and further updating in hope it fixes #182618 but the test_ccwa_response still fails on that branch (maybe due to GLib update). |
Confirmed that cherry-picking the glib 2.72.3 → 2.73.2 update breaks the tests on this branch. |
9350ec8
to
86ea750
Compare
Description of changes
https://lists.freedesktop.org/archives/modemmanager-devel/2022-April/009249.html
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes