Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modemmanager: 1.18.6 -> 1.18.10 #172742

Merged
merged 6 commits into from
Jul 26, 2022
Merged

modemmanager: 1.18.6 -> 1.18.10 #172742

merged 6 commits into from
Jul 26, 2022

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented May 12, 2022

Description of changes

https://lists.freedesktop.org/archives/modemmanager-devel/2022-April/009249.html

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Member

jtojnar commented May 12, 2022

Hmm, what does this mean for us:

  • A new connection status dispatcher setup is provided, where users can provide custom scripts that will be called on bearer connect/disconnect events. This dispatcher will make the netifd integration in openwrt work much better, as we'll be able to report network-initiated disconnections cleanly to netifd.

    There are no default connection status dispatcher scripts installed, but it's suggested distributions make sure the following directories exist:

    • ${sysconfdir}/ModemManager/connection.d/
    • ${libdir}/ModemManager/connection.d/

@amaxine
Copy link
Contributor Author

amaxine commented May 12, 2022

I somehow blanked on that when reading the changelog. As I understand, if we don't expose it it's just a feature no one can use - not replacing any existing functionality.

I suppose what we need to do here is give users a way to provide scripts via the module.

@jtojnar
Copy link
Member

jtojnar commented Jul 23, 2022

@jtojnar jtojnar force-pushed the modemmanager_1.18.8 branch from 0d92a9d to 9350ec8 Compare July 23, 2022 19:13
@jtojnar
Copy link
Member

jtojnar commented Jul 23, 2022

I took the liberty of rebasing and further updating in hope it fixes #182618 but the test_ccwa_response still fails on that branch (maybe due to GLib update).

@jtojnar
Copy link
Member

jtojnar commented Jul 23, 2022

Confirmed that cherry-picking the glib 2.72.3 → 2.73.2 update breaks the tests on this branch.

@jtojnar jtojnar changed the title modemmanager: 1.18.6 -> 1.18.8 modemmanager: 1.18.6 -> 1.18.10 Jul 23, 2022
@jtojnar jtojnar force-pushed the modemmanager_1.18.8 branch from 9350ec8 to 86ea750 Compare July 25, 2022 15:03
@jtojnar jtojnar merged commit 9b9d430 into master Jul 26, 2022
@jtojnar jtojnar deleted the modemmanager_1.18.8 branch July 26, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants