Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.mkDerivation: show test outputs as they happen #172365

Conversation

sternenseemann
Copy link
Member

Currently, the test output is only printed if the test suite fails. If a
test suite gets stuck, however, and is hit with a timeout by Hydra, it
can help to have the log available when diagnosing the issue.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Currently, the test output is only printed if the test suite fails. If a
test suite gets stuck, however, and is hit with a timeout by Hydra, it
can help to have the log available when diagnosing the issue.
@maralorn
Copy link
Member

Sounds like a good idea. Have you tried this on some packages? Won‘t it be too spamy?

@sternenseemann
Copy link
Member Author

Sure, depending on the test suite. Spammy is, however, a trend with the decisions taken in generic-builder.nix (e.g. high Cabal configure verbosity).

@sternenseemann
Copy link
Member Author

@ofborg eval

@roberth
Copy link
Member

roberth commented May 16, 2022

spammy?

The experimental CLI hides logs by default, if that's any consolation.

Having no logs hurts more than having too much of it, so 👍 .

@maralorn
Copy link
Member

Okay! I suggest merging this in after next haskell-updates merge.

@sternenseemann
Copy link
Member Author

(Could be bundled with the other set rebuild PR.)

@maralorn maralorn merged commit 62074a5 into NixOS:haskell-updates May 21, 2022
@maralorn
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants