-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R 4.2.0 #171597
Conversation
Patch needed to past test, as there are extra warnings in a sandbox build due to lack of internet access. x
RStudio is currently failing, though it's unrelated to this (RStudio doesn't like the latest glibc with the non-constexpr MINSIGSTKSZ). Doesn't seem to be a fix upstream yet. @bcdarwin ocaml-r is also failing:
I tried bumping to latest release (0.5.0) to see if this had been resolved, but then it fails to find R headers (R.h). Not sure why, it's using |
Thanks for the update! Seems like updating the r-Rhdf5lib patch would help unbreak quite a few packages, but I don't know how relevant that is. |
A lot of the new failures seem to be timeouts (hitting Hydra's 2hr limit!), meaning that we should probably look for a root cause before the next mass rebuild. |
Some of these are random Hydra failures (e.g., AlleleShift) but looks like most of them are downstream of rJava. Specifically, they're downstream of rJava and have onLoads like this (from CBSr):
This causes it to hang during the package load test. |
Patch is no-longer necessary; HDF5 no-longer vendored
Took a look and fixed it in my branch (patch no longer needed). I'll hold off pushing here until we figure out the rJava thing to avoid tying up hydra with stalling builds again. |
On my system (x64 NixOS), calling |
JDK was pinned at JDK 8, causing stalling issues with downstream rPackages (rJava and dependees).
Thanks @bcdarwin, found it: JDK was pinned at 8 for R leading to the same stall reported upstream. Unpinning appears to have resolved it; will see how Hydra goes. |
Packages that depend on Rhdf5lib also require the dev hdf5 outputs for correct functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jbedo -- this looks to be ready to merge.
I agree I think it's there, just want to bump the package set one more time. A lot of the BioC tarballs have vanished... |
I canceled your current evaluation on Hydra, as Just in case, also beware that 22.05 is being stabilized now: #165792 |
Thanks @vcunat. |
the 22.05 branch-off is scheduled to happen tomorrow. The Hydra jobset looks good to the untrained eye (i.e., me). |
Agree everything looks good, thanks all! |
Description of changes
Updates R and rPackages to next minor release.
There are more broken packages, but nothing major: https://hydra.nixos.org/jobset/nixpkgs/r-updates
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes