Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R 4.2.0 #171597

Merged
merged 7 commits into from
May 21, 2022
Merged

R 4.2.0 #171597

merged 7 commits into from
May 21, 2022

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented May 5, 2022

Description of changes

Updates R and rPackages to next minor release.

There are more broken packages, but nothing major: https://hydra.nixos.org/jobset/nixpkgs/r-updates

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

jbedo added 2 commits April 27, 2022 09:55
Patch needed to past test, as there are extra warnings
in a sandbox build due to lack of internet access.
x
@jbedo jbedo requested a review from bcdarwin May 5, 2022 01:28
@jbedo
Copy link
Contributor Author

jbedo commented May 5, 2022

RStudio is currently failing, though it's unrelated to this (RStudio doesn't like the latest glibc with the non-constexpr MINSIGSTKSZ). Doesn't seem to be a fix upstream yet.

@bcdarwin ocaml-r is also failing:

write_internal_stub.c: In function 'ocamlr_write_lisplist_carval':
write_internal_stub.c:50:21: error: invalid use of undefined type 'struct SEXPREC'
   50 |   Sexp_val(lisplist)->u.listsxp.carval = Sexp_val(elmnt);

I tried bumping to latest release (0.5.0) to see if this had been resolved, but then it fails to find R headers (R.h). Not sure why, it's using pkg-config? Don't know much about ocaml...

@ofborg ofborg bot requested review from timokau, 7c6f434c, collares and omasanori May 5, 2022 01:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels May 5, 2022
@collares
Copy link
Member

collares commented May 5, 2022

Thanks for the update! Seems like updating the r-Rhdf5lib patch would help unbreak quite a few packages, but I don't know how relevant that is.

@bcdarwin
Copy link
Member

bcdarwin commented May 5, 2022

A lot of the new failures seem to be timeouts (hitting Hydra's 2hr limit!), meaning that we should probably look for a root cause before the next mass rebuild.

@jbedo
Copy link
Contributor Author

jbedo commented May 6, 2022

A lot of the new failures seem to be timeouts (hitting Hydra's 2hr limit!), meaning that we should probably look for a root cause before the next mass rebuild.

Some of these are random Hydra failures (e.g., AlleleShift) but looks like most of them are downstream of rJava. Specifically, they're downstream of rJava and have onLoads like this (from CBSr):

.onLoad = function(libname, pkgname) {
  rJava::.jpackage(pkgname, lib.loc = libname)
  rJava::.jaddClassPath(system.file("java",package="CBSr"))
}

This causes it to hang during the package load test.

Patch is no-longer necessary; HDF5 no-longer vendored
@jbedo
Copy link
Contributor Author

jbedo commented May 6, 2022

Thanks for the update! Seems like updating the r-Rhdf5lib patch would help unbreak quite a few packages, but I don't know how relevant that is.

Took a look and fixed it in my branch (patch no longer needed). I'll hold off pushing here until we figure out the rJava thing to avoid tying up hydra with stalling builds again.

@bcdarwin
Copy link
Member

bcdarwin commented May 6, 2022

On my system (x64 NixOS), calling .jinit (which is called by .jpackage) causes a CPU-bound indefinite hang, similar to s-u/rJava#272 at the line xr <- .External(RinitJVM, boot.classpath, parameters).

JDK was pinned at JDK 8, causing stalling issues with downstream
rPackages (rJava and dependees).
@jbedo
Copy link
Contributor Author

jbedo commented May 13, 2022

Thanks @bcdarwin, found it: JDK was pinned at 8 for R leading to the same stall reported upstream. Unpinning appears to have resolved it; will see how Hydra goes.

Packages that depend on Rhdf5lib also require the dev hdf5 outputs
for correct functionality.
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbedo -- this looks to be ready to merge.

@jbedo
Copy link
Contributor Author

jbedo commented May 17, 2022

I agree I think it's there, just want to bump the package set one more time. A lot of the BioC tarballs have vanished...

@vcunat
Copy link
Member

vcunat commented May 17, 2022

I canceled your current evaluation on Hydra, as staging-next just merged to master, so the binaries would be "obsolete". You can merge master or rebase.

Just in case, also beware that 22.05 is being stabilized now: #165792

@jbedo
Copy link
Contributor Author

jbedo commented May 17, 2022

Thanks @vcunat.

@collares
Copy link
Member

the 22.05 branch-off is scheduled to happen tomorrow. The Hydra jobset looks good to the untrained eye (i.e., me).

@jbedo jbedo marked this pull request as ready for review May 21, 2022 21:18
@jbedo
Copy link
Contributor Author

jbedo commented May 21, 2022

Agree everything looks good, thanks all!

@jbedo jbedo merged commit 48a33d0 into master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants