-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qemu: add meta.mainProgram #153425
qemu: add meta.mainProgram #153425
Conversation
Waiting for end of: TO_NIXPKGS_CLONE="~/some-folder"
mkdir -pv "$TO_NIXPKGS_CLONE" \
&& nix flake clone github:PedroRegisPOAR/nixpkgs/nixpkgs-unstable --dest "$TO_NIXPKGS_CLONE" \
&& cd "$TO_NIXPKGS_CLONE" \
&& nix run nixpkgs#nixpkgs-review pr 153425 |
Please fix the commit message:
|
@ofborg eval |
Not sure I corrected the message right. I used GitKraken (UI) way to use git, so it allowed me to change the commit and pull before push, so it has a "merge commit" too 🤔 |
Yeah, definitively looks wrong. You should have only your commit here. Also, there is 3 commits. Your old commit with the old commit message is still here. |
Hope it is fixed now.
|
Motivation for this change
Using the nix cli with flakes it should be possible to not get a error message when the following command is ran:
Produces this error:
error: unable to execute '/nix/store/vfyx7mmb2q3csw1qphdcmfpx85d59jpm-qemu-6.1.0/bin/qemu': No such file or directory
Expected something like:
Things done
Just added
mainProgram = "qemu-kvm";
tometa
and it works 🎉 🚀Tested with:
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes