Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draco: 1.4.1 -> 1.4.3 #143782

Merged
merged 1 commit into from
Oct 31, 2021
Merged

draco: 1.4.1 -> 1.4.3 #143782

merged 1 commit into from
Oct 31, 2021

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Oct 30, 2021

Motivation for this change

#143631 but with fixed install directories for

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 package built:
draco

postInstall looks good:

/nix/store/n50fl3waziy1h0wxhaisrfr0i41y8nsd-draco-1.4.3/
├── bin
│   ├── draco_decoder -> draco_decoder-1.4.3
│   ├── draco_decoder-1.4.3
│   ├── draco_encoder -> draco_encoder-1.4.3
│   └── draco_encoder-1.4.3
├── include
│   └── draco
│       ├── animation
│       ├── attributes
│       ├── compression
│       ├── core
│       ├── draco_features.h
│       ├── io
│       ├── mesh
│       ├── metadata
│       ├── point_cloud
│       └── unity
├── lib
│   ├── libdraco.a
│   ├── libdracodec_unity.so
│   └── pkgconfig
│       └── draco.pc
└── share
    └── cmake
        └── draco-config.cmake

@7c6f434c
Copy link
Member

On the one hand, most likely it would be better to pass some parameter do cmake to install. On the other hand, leaf package with an annoying upstream packaging bug, maybe it will go away on its own.

@7c6f434c 7c6f434c merged commit 53963a8 into NixOS:master Oct 31, 2021
@jansol
Copy link
Contributor Author

jansol commented Oct 31, 2021

Yeah, I took a quick look at the upstream build files but didn't find any obvious parameter for this. The usual CMAKE_INSTALL_PREFIXseems to get mangled somehow. I'll do a bit more digging later and open an issue upstream.

@jansol jansol deleted the draco branch October 31, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants