neofetch: apply patch to fix neofetch returning wrong icon theme

[rhoriguchi]

Motivation for this change

Fixes issue #108903.

Since upstream hasn't merged the open dylanaraps/neofetch#1873 I've added a patch that fixes the mentioned issue.

cc: @lilyinstarlight

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[lilyinstarlight]

I planned to PR this too since it's been over a month, but I got distracted and you beat me to it 🙂

Would it be better to link to the patch by commit hash instead of PR number so if I push new commits to the branch, it won't invalidate the hash? Like for example:

fetchpatch {
  url = "https://github.com/dylanaraps/neofetch/commit/413c32e55dc16f0360f8e84af2b59fe45505f81b.patch";
  sha256 = "sha256-8Eamexxvr7wQkVouQWxehCtSljjxucP3kMCl89NrV7k=";
  name = "avoid_overwriting_gio_extra_modules_env_var.patch";
}

[rhoriguchi]

I planned to PR this too since it's been over a month, but I got distracted and you beat me to it slightly_smiling_face

Would it be better to link to the patch by commit hash instead of PR number so if I push new commits to the branch, it won't invalidate the hash? Like for example:

fetchpatch {
  url = "https://github.com/dylanaraps/neofetch/commit/413c32e55dc16f0360f8e84af2b59fe45505f81b.patch";
  sha256 = "sha256-gmR0SqCZTCKIMJsIa/OoZ/K7qzlntgLJBAZFrScKiFs=";
  name = "avoid_overwriting_gio_extra_modules_env_var.patch";
}

Good point. I've update it.

[lilyinstarlight]

Good point. I've update it.

Awesome! I'll also note that the issue manifested in both the reported GTK3 theme and icon theme for me, so I imagine any gsettings in dconf were being missed by neofetch

[rhoriguchi]

@SuperSandro2000 please close the issue #108903.