Revert google-fonts update to unstable, fixing Inconsolata

[jb55]

Motivation for this change

An update to an unstable version of google-fonts broke the Inconsolata monospace font in programs that use xft such as urxvt. This PR reverts some recent google-fonts commits back to the stable version.

See:

googlefonts/Inconsolata#42
https://discourse.nixos.org/t/how-to-fix-broken-inconsolata-font-in-urxvt-on-21-05/13437

cc @jakubgs @06kellyjac @petabyteboy @tu-maurice

[r-rmcgibbo]

Result of nixpkgs-review pr 130209 at 0ffd2b9 run on x86_64-linux 1

2 packages built successfully:

• inconsolata
• ricty

1 suggestion:

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/data/fonts/inconsolata/default.nix:8:3:

    |
  8 |   installPhase = ''
    |   ^
  

---

Result of nixpkgs-review pr 130209 at 0ffd2b9 run on aarch64-linux 1

1 package built successfully:

• inconsolata

1 suggestion:

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/data/fonts/inconsolata/default.nix:8:3:

    |
  8 |   installPhase = ''
    |   ^
  

[06kellyjac]

I'm against this for 2 reasons

1. It's not just reverting the src but also reverting improvements like setting it to stdenvNoCC (which inconsolata/default.nix should use too)
2. The inconsolata/default.nix can just change it's own src to refer to an older working commit of google/fonts rather than reverting every other font in the google-fonts repo to 2019

Edit: also calling the previous dated version stable is not true, google/fonts doesn't have any stable releases, every dated release of google/fonts is unstable. It's just someone changed the version text to make that clear

[jb55]

ah good point on just updating inconsolata/default.nix, will open a new PR

[06kellyjac]

Thanks @jb55 🎉