buildPythonPackage: fix typos #11590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @domenkozar, @civodul and @offlinehacker to be potential reviewers |
|
Hmm, this will rebuild a lot of python packages. Best if we merge it together with some other work. |
|
Thank btw! :) |
| @@ -112,7 +112,7 @@ python.stdenv.mkDerivation (builtins.removeAttrs attrs ["disabled" "doCheck"] // | |||
| postFixup = attrs.postFixup or '' | |||
| wrapPythonPrograms | |||
|
|
|||
| # check if we have two packagegs with the same name in closure and fail | |||
| # check if we have two packages with the same name in closure and fail | |||
| # this shouldn't happen, something went wrong with dependencies specs | |||
There was a problem hiding this comment.
if we move comments out of the arguments, then future changes should not cause any rebuilds, right?
|
@FRidh could we also take these changes to |
|
Fixed in 606616e09992cc8910bca62f5db643a9265a3c7a, will land shortly in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.