Skip to content

Commit

Permalink
faiss: move to by-name
Browse files Browse the repository at this point in the history
  • Loading branch information
GaetanLepage committed Jan 31, 2025
1 parent 1782a3c commit 97ffcf9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
cudaPackages ? { },
cudaSupport ? config.cudaSupport,
pythonSupport ? true,
pythonPackages,
python3Packages,
llvmPackages,
blas,
swig,
Expand Down Expand Up @@ -67,17 +67,17 @@ stdenv.mkDerivation {
autoAddDriverRunpath
]
++ lib.optionals pythonSupport [
pythonPackages.python
pythonPackages.setuptools
pythonPackages.pip
python3Packages.python
python3Packages.setuptools
python3Packages.pip
];

buildInputs =
[
blas
swig
]
++ lib.optionals pythonSupport [ pythonPackages.numpy ]
++ lib.optionals pythonSupport [ python3Packages.numpy ]
++ lib.optionals stdenv.cc.isClang [ llvmPackages.openmp ]
++ lib.optionals cudaSupport cudaComponents;

Expand Down
4 changes: 0 additions & 4 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -17365,10 +17365,6 @@ with pkgs;
jre = openjdk17;
};

faiss = callPackage ../development/libraries/science/math/faiss {
pythonPackages = python3Packages;
};

faissWithCuda = faiss.override {
cudaSupport = true;
};
Expand Down
2 changes: 1 addition & 1 deletion pkgs/top-level/python-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -4448,7 +4448,7 @@ self: super: with self; {
faiss = callPackage ../development/python-modules/faiss {
faiss-build = pkgs.faiss.override {
pythonSupport = true;
pythonPackages = self;
python3Packages = self;
};
};

Expand Down

0 comments on commit 97ffcf9

Please sign in to comment.