Skip to content

Commit

Permalink
ocamlPackages.core_unix: fix for OCaml 5.3
Browse files Browse the repository at this point in the history
  • Loading branch information
vbgl committed Jan 28, 2025
1 parent 30b1f56 commit 3d76918
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions pkgs/development/ocaml-modules/janestreet/0.17.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
self,
bash,
fetchpatch,
fzf,
lib,
openssl,
Expand Down Expand Up @@ -498,6 +499,13 @@ with self;
patchShebangs unix_pseudo_terminal/src/discover.sh
'';
doCheck = false; # command_validate_parsing.exe is not specified in test build deps

# Compatibility with OCaml 5.3
patches = lib.optional (lib.versionAtLeast ocaml.version "5.3") (fetchpatch {
url = "https://github.com/janestreet/core_unix/commit/ebce389ac68e098f542e34400e114ac992f415af.patch";
includes = [ "bigstring_unix/src/bigstring_unix_stubs.c" ];
hash = "sha256-FGg2zlyp3aZFu1VeFdm7pgSPiW0HAkLYgMGTj+tqju8=";
});
};

csvfields = janePackage {
Expand Down
2 changes: 1 addition & 1 deletion pkgs/top-level/ocaml-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ let
then import ../development/ocaml-modules/janestreet/0.17.nix
{
inherit self;
inherit (pkgs) bash fzf lib openssl zstd;
inherit (pkgs) bash fetchpatch fzf lib openssl zstd;
}
else if lib.versionOlder "4.13.1" ocaml.version
then import ../development/ocaml-modules/janestreet/0.16.nix {
Expand Down

0 comments on commit 3d76918

Please sign in to comment.