Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect TERM=dumb more consistently #4971

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Respect TERM=dumb more consistently #4971

merged 2 commits into from
Jul 2, 2021

Conversation

ylh
Copy link
Contributor

@ylh ylh commented Jul 2, 2021

This is a huge quality-of-life improvement for my niche use case:
current
patched

@edolstra
Copy link
Member

edolstra commented Jul 2, 2021

Looks good, but maybe instead of TERM=dumb we should respect NO_COLOR instead or additionally (see https://no-color.org/).

@ylh
Copy link
Contributor Author

ylh commented Jul 2, 2021

First time hearing of that convention, but by the looks of it, checking for both seems like the most sensible option. I've tacked on a commit accordingly.

@edolstra edolstra merged commit 7a3f43c into NixOS:master Jul 2, 2021
@edolstra
Copy link
Member

edolstra commented Jul 2, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants