-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stale bot #4526
Add Stale bot #4526
Conversation
The configuration was taken from nixpkgs repository and adjusted to `NixOS/nix`. A `stale` label was added to the labels (with gray color). Issues and PRs with `critical` label are excluded from interacting with the stale bot.
.github/stale.yml
Outdated
@@ -0,0 +1,9 @@ | |||
# Configuration for probot-stale - https://github.com/probot/stale | |||
daysUntilStale: 180 | |||
daysUntilClose: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's auto-close issues/PRs older than (say) 1 year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but only if nobody comments on them to keep them open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I think what was not said is that even when an issue gets closed, it can be reopened if there is enough interest. Currently it is obvious that there is a management problem, since at the time of writing this we have 1.3k issues and 203 PRs open.
At the same time I'm not trying to say that by closing the issues those issues go away. Far from it. Being closed (and with a stale label) it means there was not enough interest to solve them.
And what happens is that this stale bot in a lot of cases serve as a reminder to get back to the issues/PRs. I know this happened to me on quite few occasions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The auto-closing is starting to kill contributions that I think shouldn't be killed:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iirc the open PR count had been hovering between 291 and 296 recently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing was a terrible idea, and done in contra to the community's decision for Nixpkgs in https://github.com/NixOS/rfcs/blob/master/rfcs/0051-mark-stale-issues.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have opened an RFC for this at NixOS/rfcs#124
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-7/11552/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/stale-bot-for-nix-just-closed-a-bunch-of-stuff/18661/2 |
The configuration was taken from nixpkgs repository and adjusted to
NixOS/nix
.A
stale
label was added to the labels (with gray color).Issues and PRs with
critical
label are excluded from interacting with thestale bot.
Fixes #4522