Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update piv to 0.4.0 #592

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Update piv to 0.4.0 #592

merged 3 commits into from
Mar 6, 2025

Conversation

sosthene-nitrokey
Copy link
Collaborator

This actually updates piv to Nitrokey/piv-authenticator#74 to avoid having an intermediary commit that does not compile.

@sosthene-nitrokey sosthene-nitrokey marked this pull request as draft February 13, 2025 10:22
@nitrokey-ci
Copy link
Collaborator

nitrokey-ci commented Feb 13, 2025

No significant changes.

Insignifcant changes
metric value change
binary-size-nk3am 1,500,253 🔴 +810 (+0.05%)
binary-size-nk3am-test 1,873,996 🔴 +733 (+0.04%)
binary-size-nk3xn 537,600 🔴 +304 (+0.06%)
binary-size-nk3xn-test 537,664 🔴 +304 (+0.06%)
binary-size-nkpk 681,970 -119 (-0.02%)

@sosthene-nitrokey sosthene-nitrokey marked this pull request as ready for review February 21, 2025 13:40
@robin-nitrokey
Copy link
Member

Can you please rebase and merge this PR? It would be good to create the next release on top of v1.8.1.

@sosthene-nitrokey
Copy link
Collaborator Author

Updating to 0.4.0: Nitrokey/piv-authenticator#76 for the test release

@sosthene-nitrokey sosthene-nitrokey changed the title Update piv to 0.3.9 Update piv to 0.4.0 Mar 5, 2025
@robin-nitrokey
Copy link
Member

I think it would also make sense to update the minimum apdu-dispatch version in this PR so that #591 only contains the optional updates.

@sosthene-nitrokey sosthene-nitrokey merged commit b118079 into main Mar 6, 2025
11 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the update-piv-1.8.1 branch March 6, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants