Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that comparisons are not identically false #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mizabrik
Copy link
Contributor

No description provided.

@mizabrik mizabrik requested a review from ayashunsky January 22, 2025 00:21
Copy link

github-actions bot commented Jan 22, 2025

Clang Test Results

  168 files  ± 0    168 suites  ±0   15m 43s ⏱️ -4s
8 441 tests  - 97  8 435 ✅  - 97  6 💤 ±0  0 ❌ ±0 
8 507 runs   - 97  8 501 ✅  - 97  6 💤 ±0  0 ❌ ±0 

Results for commit 159cefc. ± Comparison against base commit 94766b9.

This pull request removes 103 and adds 6 tests. Note that renamed tests count towards both.
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
pack_equal_test_suite ‑ bubb_to_bubb_1
pack_equal_test_suite ‑ bubb_to_bubb_2
pack_equal_test_suite ‑ bubb_to_bubb_3
pack_equal_test_suite ‑ bubb_to_bulb_1
pack_equal_test_suite ‑ bubb_to_bulb_2
pack_equal_test_suite ‑ bubb_to_lubb_1
…
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 22, 2025

Gcc Test Results

  168 files  ±0    168 suites  ±0   16m 51s ⏱️ +16s
8 534 tests  - 4  8 528 ✅  - 4  6 💤 ±0  0 ❌ ±0 
8 600 runs   - 4  8 594 ✅  - 4  6 💤 ±0  0 ❌ ±0 

Results for commit 159cefc. ± Comparison against base commit 94766b9.

This pull request removes 5 and adds 1 tests. Note that renamed tests count towards both.
blueprint_plonk_test_suite ‑ blueprint_non_native_multiplication_pallas
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
blueprint_plonk_test_suite ‑ blueprint_non_native_addition_pallas

♻️ This comment has been updated with latest results.

@mizabrik mizabrik force-pushed the fix-cmp-completeness branch from dca7a69 to 7427e03 Compare January 22, 2025 13:30
@mizabrik mizabrik force-pushed the fix-cmp-completeness branch from 7427e03 to 159cefc Compare January 27, 2025 15:18
@mizabrik mizabrik requested review from ETatuzova and removed request for ayashunsky January 27, 2025 15:19
@@ -169,8 +176,6 @@ namespace nil {
// constrain(diff * (diff * diff_inv - 1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment constraints that are similar to CMP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants