Add call args playground validation and fix multiple token inputs issue #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukorvl
force-pushed
the
playground-call-args-inputs-validation
branch
from
2258e34 to
d8cbc7f
Compare
ukorvl
force-pushed
the
playground-call-args-inputs-validation
branch
from
d8cbc7f to
9041354
Compare
KlonD90
reviewed
Feb 28, 2025
| @@ -140,7 +140,7 @@ createSmartAccountFx.use(async ({ privateKey, rpcUrl }) => { | |||
| { | |||
| smartAccountAddress: smartAccount.address, | |||
| faucetAddress: tokenFaucetAddress, | |||
| amount: 10, | |||
| amount: 10n, | |||
There was a problem hiding this comment.
that's kinda small? if it's wei it's just 0.00...0001
|
Converting this to draft because will be able to merge only after vacation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23
This diff fixes several issues related to playground.
Firs off, it fixes the problem with multiple token inputs, described in #424 by extending object, which stores the values and adding 1 more depth level to it for each of the smart contract functions.
The second issue it fixes - lack of client side smart contract function input fields validation. The diff introduces new effector domain for validation of call params, including validation of tuples.
Also, it fixes the display of result of a smart contract function call. Sometimes result can be an array of values, that are returned by function, and we want to display them using comma separator with additional space
,.It fixes the problem with extra spaces at the beginning of rpc url, like
https://, which were considered invalid, by trimming the value before validation.Additionally it moves some modules, which is not a significant change.
Screen.Recording.2025-02-28.at.00.39.16.mov