Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Committee: Parent-child batch linking #388

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

zadykian
Copy link
Member

@zadykian zadykian commented Feb 24, 2025

Sync Committee: Parent-child batch linking

  • Introduced parent-child links between block batches (BlockBatch.ParentId field). First batch generated by SyncCommittee is expected to have nil parent;

  • Introduced functionality to track the latest batch ID in BlockStorage and link block batches through parent batch IDs;

Links between batches created by SC are required to restore batches sequence during task cancellation process

Copy link

@zadykian zadykian self-assigned this Feb 24, 2025
@zadykian zadykian force-pushed the sync-committee/blocks-reset branch from 1eb5bf9 to 8ef2c7b Compare February 25, 2025 12:02
@zadykian zadykian force-pushed the sync-committee/parent-batch-ids branch from 40abc33 to 7609389 Compare February 25, 2025 12:35
@zadykian zadykian marked this pull request as ready for review February 25, 2025 12:37
Base automatically changed from sync-committee/blocks-reset to main February 25, 2025 12:40
@zadykian zadykian marked this pull request as draft February 25, 2025 13:13
@zadykian zadykian force-pushed the sync-committee/parent-batch-ids branch from 7609389 to 3e0bb61 Compare February 25, 2025 13:44
@zadykian zadykian closed this Mar 5, 2025
@zadykian zadykian force-pushed the sync-committee/parent-batch-ids branch from 3e0bb61 to 6579ec6 Compare March 5, 2025 11:26
@zadykian zadykian reopened this Mar 5, 2025
@zadykian zadykian force-pushed the sync-committee/parent-batch-ids branch from c15bc8c to 189c262 Compare March 5, 2025 12:21
Copy link

* Introduced parent-child links between block batches (`BlockBatch.ParentId` field). First batch generated by SyncCommittee is expected to have `nil` parent;

* Introduced functionality to track the latest batch ID in `BlockStorage` and link block batches through parent batch IDs;

Links between batches created by SC are required to restore batches sequence during task cancellation process. Used in #419
@zadykian zadykian added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 410e37c Mar 10, 2025
14 checks passed
@zadykian zadykian deleted the sync-committee/parent-batch-ids branch March 10, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants