use non-default ports for clickhouse #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
force-pushed
the
fix-other-par-workflow
branch
from
9fd491e to
b612bb6
Compare
olegrok
force-pushed
the
fix-other-par-workflow
branch
from
b612bb6 to
af37cfa
Compare
olegrok
force-pushed
the
fix-other-par-workflow
branch
from
af37cfa to
ae1d946
Compare
olegrok
force-pushed
the
fix-other-par-workflow
branch
from
ae1d946 to
1f9a530
Compare
olegrok
force-pushed
the
fix-other-par-workflow
branch
from
13501c3 to
5b3c0ff
Compare
avm
reviewed
Jan 27, 2025
There was a problem hiding this comment.
I like the approach of assigning ports to make tests parallel! I suggest we make a text file listing all of those assignments (like "nil/tests/cometa: 9002; nil/tests/journald_forwarder: 9001"), so that if you need a port for a new test, you don't have to search through all the tests.
|
Even with fixes I get I don't understand how we can fix ThreadSanitizer... |
olegrok
force-pushed
the
fix-other-par-workflow
branch
from
5b3c0ff to
74c8b68
Compare
olegrok
force-pushed
the
fix-other-par-workflow
branch
from
74c8b68 to
56b86db
Compare
As it was suggested in review.
Ok. Done c50ae4d |
Seems it helps to prevent following issue: ``` 2025-01-27T20:18:44.9644193Z nil> ThreadSanitizer: failed to restore address 0x100675c0eb0 2025-01-27T20:18:44.9644532Z nil> FAIL github.com/NilFoundation/nil/nil/services/synccommittee/prover/tracer 70.749s 2025-01-27T20:18:44.9644974Z nil> ok github.com/NilFoundation/nil/nil/services/synccommittee/prover/tracer/internal/mpttracer 1.228s ``` I don't understand that is a reason of such failure but seems it helps in case we decrease memory pressure during the test.
avm
approved these changes
Jan 28, 2025
Gezort
pushed a commit
that referenced
this pull request
Feb 19, 2025
use non-default ports for clickhouse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests (cometa + journald_forwarder) conflicted because of Clickhouse. This patch fixes it.