Merge pull request #497 from NilFoundation/fix-metrics

[consensus] fix invalid metric usage
NilFoundation · Mar 7, 2025 · 9a3d29c · 9a3d29c
2 parents 55b9ee8 + 40a6f01
commit 9a3d29c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/nil/internal/consensus/ibft/ibft.go b/nil/internal/consensus/ibft/ibft.go
@@ -147,8 +147,8 @@ func (i *backendIBFT) buildSignature(committedSeals []*messages.CommittedSeal, h
 }
 
 func (i *backendIBFT) InsertProposal(proposal *protoIBFT.Proposal, committedSeals []*messages.CommittedSeal) {
-	i.mh.StartBuildProposalMeasurement(i.transportCtx, proposal.Round)
-	defer i.mh.EndBuildProposalMeasurement(i.transportCtx)
+	i.mh.StartInsertProposalMeasurement(i.transportCtx, proposal.Round)
+	defer i.mh.EndInsertProposalMeasurement(i.transportCtx)
 
 	proposalBlock, err := i.unmarshalProposal(proposal.RawProposal)
 	if err != nil {

diff --git a/nil/internal/consensus/ibft/metrics.go b/nil/internal/consensus/ibft/metrics.go
@@ -91,7 +91,7 @@ func (mh *MetricsHandler) StartInsertProposalMeasurement(ctx context.Context, ro
 	mh.insertProposalMeasurer.Restart()
 }
 
-func (mh *MetricsHandler) EndInsertProposalMeasurement(ctx context.Context, height, round uint64) {
+func (mh *MetricsHandler) EndInsertProposalMeasurement(ctx context.Context) {
 	mh.insertProposalMeasurer.Measure(ctx)
 }