This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Convert to the required integral type when multiplying a scalar with a curve point. #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiplying an EC curve point to a scalar value, the scalar must be integral_type, not value_type, and it must be of the same bit-length as the group used for EC scalar values. The caller must convert it to the corrent integral type before multiplying.
Yet we have lots of use cases mostly in blueprint where an integral_type number of different field is multiplied by and EC point. In these cases we will convert them in algebra itself, for now. Later we may consider moving this conversions to the callers and deleting this operator*.