This repository was archived by the owner on Feb 17, 2025. It is now read-only.
135 lpc batching #136
Closed
135 lpc batching #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
martun
approved these changes
Feb 1, 2024
ETatuzova
force-pushed
the
135-lpc-batching
branch
2 times, most recently
from
b30c32c to
22b8b9f
Compare
AndreyMlashkin
pushed a commit
that referenced
this pull request
Aug 15, 2024
…nents. (#136) Closes #130. Bit (de)composition currently only works when the amount of bits is less than amount of bits in field modulus. Bit components support two modes: MSB/LSB first in output/input respectively. Bit composition can optionally check that it's inputs are bits (belong to {0, 1}), or assume that the check has already been performed. Logic components assume that their inputs are bits, and do not perform a check. Bit shifts are only implemented for constant shift amounts. * Added logic operations. * Corrected nor test and added initializer_list constructor. * Bit composition for < modulus_size bits. * Corrected gate amount calculation. Added a component schematic. * Remade bit_composition to utilise a single gate. * Made bit_(de)composition component generic. * Corrected bit_decomposition not checking that output is bits. * Stopped allocating constants when they were not required. * Shortened long lines in boolean/logic component. * Added new tests to test runner. * Standard compliance. * Bit shift component added. Minor code cleanup. * Corrected constant rows amount calculation in bit_shift. * Changed file structure; moving to multiple implementations of bit_builder. * Swtiched to a single (de)composition implementation. * Renamed bit_shift to bit_shift_constant. * Added regression test for 1 bit (de)composition. * Forced 15 Witnesses for compatibility with compiler. * Updated tests. Upgraded bit_shift to accept multiple value sizes. * Added more tests for bit_composition/bit_shift. * Moved template arguments to constructors. * Corrected bad initialization of bit_builder_component.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.