This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Improve template android #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
June 26, 2017 10:24
bin/gyro
Outdated
| @@ -16,6 +16,8 @@ | |||
|
|
|||
| abort 'error: gyro requires Ruby 2 or higher.' if RUBY_VERSION < '2.0.0' | |||
|
|
|||
| $LOAD_PATH.unshift File.expand_path('../lib', File.dirname(__FILE__)) if $PROGRAM_NAME == __FILE__ | |||
There was a problem hiding this comment.
This line is no longer be useful. If you want to test gyro locally, please use the following lines :
gem build gyro.gemspec
gem install gyro-1.0.0.gemThere was a problem hiding this comment.
or you can use an other command when you develop gyro. Go to gyro repo and launch :
ruby -Ilib bin/gyro -m <model> -t android -o <output>
StevenWatremez
suggested changes
Sep 12, 2017
StevenWatremez
approved these changes
Sep 12, 2017
StevenWatremez
pushed a commit
that referenced
this pull request
Sep 13, 2017
* Allow direct local execution * Improve templates * Avoid useless enum member * Hide setter and getter for fields with enum values * Better template for enums * Fix issue * Fix issue with hide_members_with_enum not working * Class with private constructor have to be final * Improve template * Fix Java fixtures * fix issue with annotations * Fix regression with annotations * Fix all java fixture * Fix issue with extra empty lines * Fix issue on comment. Note: comment on relationship does not work * Fix rubocop offenses * Fix rubocop offense * Fix sonar issue about order of elements * Fix sonar issue about order of elements - update unitary tests * fix injected params check * fix primitive anotations * remove $LOAD_PATH
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the template I currently use on my application. It fixes some mistake on Java formatting code.
It also remove the @Ignore-d fields due to Enum feature.
For Enum an option to hide the getter and setter of the base method has been added, but is still not working (-p hide_members_with_enum:true), so the branch is not ready yet to be merged.
Please note that the fixture has not been updated (I can do it if the PR is validated, before the merge)
This PR has been created to discuss about it.