Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource string for the newly added Stop Sensor Confirmation #1726

Merged

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented May 16, 2021

Adding a resource string for the stop sensor confirmation that was added with build 2021.05.16 (84e4376).

@Navid200 Navid200 requested a review from tolot27 May 16, 2021 21:17
Copy link
Collaborator

@tolot27 tolot27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please always provide a description and refer the original commit (84e4376 in this case), if appropriate. Thanks!

@tolot27 tolot27 changed the title Added Resource String for the newly added Stop Sensor Confirmation Add resource string for the newly added Stop Sensor Confirmation May 16, 2021
Copy link
Collaborator

@tolot27 tolot27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is evident for non-English users to fully understand the consequences of the stop sensor confirmation dialog, it is important to provide a translatable resource string.

@tolot27 tolot27 added the next-build PRs to consider for the next build. label May 21, 2021
@jamorham
Copy link
Collaborator

Since this string probably is unlikely to change much then this makes sense, in future we can use the translatable="false" suggestion for strings where the wording may change during the early stages of a feature.

@jamorham jamorham merged commit c87cf03 into NightscoutFoundation:master May 21, 2021
@tolot27 tolot27 removed the next-build PRs to consider for the next build. label May 21, 2021
@Navid200 Navid200 deleted the StopSensorConfirmTranslation branch May 28, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants