Fix recursive deletion of directory not possible #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 👍 |
|
@Nicolab Do you got any plans for a new release which includes these changes? |
|
Oops, missed! It's done :) |
Nicolab
added a commit
that referenced
this pull request
Mar 9, 2020
[FtpClient] fix bug introduced by #48
|
I had to go back to my original behavior. In my opinion for your problem, you need to see the directory path you're passing. Maybe "rmdir" with the parameters "test-folder" (without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of "rmdir" is not able to recursively remove a directory.
If the "recursive" flag is set, a file list of the given directory is created (via nlist) and the loop deletes all these files. I think the directory is missing in this call if no "chdir" is performed.
In my case, my working directory was "/" and I called "rmdir" with the Parameters "/test-folder" and "true". The folder contained files and directories, so this function didn't delete anything although the recursive flag was set to "true".