Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDV diagnostic messages #2690

Merged
merged 15 commits into from
Feb 20, 2025
Merged

SDV diagnostic messages #2690

merged 15 commits into from
Feb 20, 2025

Conversation

Pickysaurus
Copy link
Contributor

@Pickysaurus Pickysaurus commented Feb 19, 2025 •
edited
Loading

  • Edited all Stardew Valley diagnostic messages to follow the format started by @Sewer56 during his Bannerlord work.
  • Added a couple of new NamedLinks to diagnostics (this involved modifying the imports for SMAPIGameVersionDiagnosticEmitter.cs
  • Added txt files per-diagnostic to give test instructions (this could be improved later)
  • Upgraded the XNB mod diagnostic from "Information" to "Warning"

@Pickysaurus
Updated MissingRequiredDependencyTemplate for Stardew Valley
459b332
@Pickysaurus
Updated RequiredDependencyIsOutdatedTemplate
43f5690
@Pickysaurus
Updated more diagnostic messages and test cases.
741f516
@Pickysaurus
Merge remote-tracking branch 'origin/main' into sdv-diagnostic-messages
1806039
@Pickysaurus
Merge remote-tracking branch 'origin/main' into sdv-diagnostic-messages
39b3cb1
@Pickysaurus
Fixes #2681
b009efa
@Pickysaurus
Added more test cases and messages
65312f6 
Upgraded the XNB diagnostic from "Suggestion" to "Warning".
@Pickysaurus
Updated title and summary for ModOverwritesGameFilesTemplate
cbbd7f7
@Pickysaurus
Merge remote-tracking branch 'origin/main' into sdv-diagnostic-messages
3a77db8
@Pickysaurus
Converted links to use NamedLink
3973206 
Renamed DefaultWikiLink in SMAPIModDatabaseCompatibilityDiagnosticEmitter to SMAPIModCompatibilityLink to better reflect where the URL is pointing.
Added test cases for SMAPI/Game version mismatches
@Pickysaurus
Added missing comma!
6103291
@Pickysaurus Pickysaurus marked this pull request as ready for review February 20, 2025 11:36
@Pickysaurus Pickysaurus requested a review from a team February 20, 2025 11:37
@Pickysaurus Pickysaurus self-assigned this Feb 20, 2025
@Pickysaurus Pickysaurus added the Epic: Diagnostics This is related to the Diagnostic System label Feb 20, 2025
@Pickysaurus Pickysaurus added this to the SDV Beta Release milestone Feb 20, 2025
Al12rs
Al12rs reviewed Feb 20, 2025
View reviewed changes
src/Games/NexusMods.Games.StardewValley/Diagnostics.cs

### How to Resolve
1. Download the latest version of **{Dependency}** from {NexusModsDependencyUri}
2. Add the latest version of **{Dependency}** to the loadout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say to download version {MinimumVersion} or greater instead perhaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fc642e0

Al12rs
Al12rs approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions above, but otherwise looks fine

@Pickysaurus Pickysaurus merged commit d7f2507 into main Feb 20, 2025
7 checks passed
@Pickysaurus Pickysaurus deleted the sdv-diagnostic-messages branch February 20, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al12rs Al12rs Al12rs approved these changes

Assignees

@Pickysaurus Pickysaurus

Labels
Epic: Diagnostics This is related to the Diagnostic System
Projects
MVP
Status: Done
Milestone
SDV Beta Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Pickysaurus @Al12rs