Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move toolbar into tabs #2364

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Move toolbar into tabs #2364

merged 4 commits into from
Dec 11, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Dec 11, 2024

Part of #2254. UI styling needs updating.

@erri120 erri120 requested a review from a team December 11, 2024 12:57
@erri120 erri120 self-assigned this Dec 11, 2024
Al12rs
Al12rs requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about TreeDataGrid inside a StackPanel

@erri120 erri120 requested a review from Al12rs December 11, 2024 13:57
@Al12rs
Copy link
Contributor

Al12rs commented Dec 11, 2024

You can't interact with the buttons right now with this change:
image

Al12rs
Al12rs requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't press the download buttons

@erri120
Copy link
Member Author

erri120 commented Dec 11, 2024

You can't interact with the buttons right now with this change: image

What collection is that?

@Al12rs
Copy link
Contributor

Al12rs commented Dec 11, 2024 •
edited
Loading

You can't interact with the buttons right now with this change: image

What collection is that?

This one, I can reproduce with others
https://next.nexusmods.com/stardewvalley/collections/cwovfq

@erri120 erri120 requested a review from Al12rs December 11, 2024 14:25
Al12rs
Al12rs approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly now

@Al12rs Al12rs merged commit fcc46e3 into Nexus-Mods:main Dec 11, 2024
11 checks passed
@erri120 erri120 deleted the feat/2254-8 branch December 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al12rs Al12rs Al12rs approved these changes

Assignees

@erri120 erri120

Labels
None yet
Projects
MVP
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erri120 @Al12rs