Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free Pill UI Banner #2118

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Free Pill UI Banner #2118

merged 3 commits into from
Oct 9, 2024

Conversation

MistaOmega
Copy link
Contributor

Closes #1535

Premium still working:
image

Free:
image

@Pickysaurus
Copy link
Contributor

We'll need to check with @captainsandypants but I think the "FREE" text not being there is intended.

@MistaOmega
Copy link
Contributor Author

Also looked back at the issue and realised I didn't make it link to the page requested, so I should do that if this ends up still be required

@captainsandypants
Copy link
Collaborator

I don't mind this being a thing for now but plan to explore having a "Get premium" type button up there

@Pickysaurus
Copy link
Contributor

Also looked back at the issue and realised I didn't make it link to the page requested, so I should do that if this ends up still be required

@MistaOmega if possible can you add the link as the original ticket mentions? I think we can merge it for now. Although as captainsandypants said it will be changed at some point in the future!

@MistaOmega
Copy link
Contributor Author

@Pickysaurus I've added the interactivity
As with the styling of the original although it isn't really obvious when you're interacting with it, or that it IS interactive

May actually be worth just using a button? Or I can add a hover effect and lil border radius like on the TopBarMenuItem class, but with a transparent background

@MistaOmega
Copy link
Contributor Author

@erri120 for note i've changed the other 2 uses of new Uri, to use the builder also

@Al12rs Al12rs merged commit bfa991a into Nexus-Mods:main Oct 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Free Pill
6 participants