Added: Minimum Size to Main Window #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al12rs
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Please see our notes on minimum size as discussed here:
#1109 (comment)
Al12rs
requested changes
Aug 28, 2024
Co-authored-by: Al <[email protected]>
Al12rs
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minimum size requirement to the window, which I've set approximately to the following:
The main motivation here is adding a temporary workaround for
And to be consistent with other windows which have minimum sizes.
Though, after merging, I'm not sure if we should close the original issue.
I think it may be worthwhile to do a few more quick tests and report the bug upstream to Avalonia.