Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metadata files #1689

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Update metadata files #1689

merged 4 commits into from
Jun 26, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jun 26, 2024

Required for #1668 and #1669.

@erri120 erri120 requested a review from a team June 26, 2024 11:14
@erri120 erri120 self-assigned this Jun 26, 2024
Al12rs
Al12rs reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but I wouldn't really know if there were issues.

@erri120 erri120 requested a review from Sewer56 June 26, 2024 12:42
@erri120
Copy link
Member Author

erri120 commented Jun 26, 2024

CC @MattSturgeon and @l0b0 if you want to take a look. com.nexusmods.app.desktop and com.nexusmods.app.metainfo.xml will be made available as static files with this PR.

@erri120 erri120 merged commit f2bbcb4 into Nexus-Mods:main Jun 26, 2024
11 checks passed
@erri120 erri120 deleted the feat/metadata-files branch June 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al12rs Al12rs Al12rs left review comments

@halgari halgari halgari approved these changes

@Sewer56 Sewer56 Awaiting requested review from Sewer56

Assignees

@erri120 erri120

Labels
None yet
Projects
MVP
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erri120 @halgari @Al12rs