Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: As Many UI Issues as I can Handle #1622

Merged
merged 37 commits into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
09a3aad
Fixed: Icon and UI Element Sizes throughout Various Parts of App
Sewer56 Jun 13, 2024
10043a7
Merge remote-tracking branch 'origin/main' into fixup-icons
Sewer56 Jun 13, 2024
e6b8a0a
Merge remote-tracking branch 'origin/main' into fixup-icons
Sewer56 Jun 13, 2024
a320027
Fixed: My Games icon now shows filled GamePad, like on Website
Sewer56 Jun 13, 2024
63b1b84
Removed: Legacy Unused Game Icon
Sewer56 Jun 13, 2024
e84daa1
Merge remote-tracking branch 'origin/main' into fixup-icons
Sewer56 Jun 13, 2024
ad12a3d
LoadoutGrid now shows correct PlaylistRemove instead of Close Button
Sewer56 Jun 13, 2024
84839ce
Rename: Health Check -> Health Check
Sewer56 Jun 13, 2024
43b1e74
Removed: Deprecated Description Icon
Sewer56 Jun 13, 2024
3975779
Improved: Actions Section in Mod Library
Sewer56 Jun 13, 2024
1017a0b
Fix Casing on `Advanced add` and `View Mod files`
Sewer56 Jun 13, 2024
46b831d
Fixed: Incorrect (missing) scale on Download Button Click
Sewer56 Jun 13, 2024
5a44c27
Expanded FileOriginsView Actions Min Width as to not clip text
Sewer56 Jun 13, 2024
f3fe49b
Fixed: Diagnostic Details showing Wrong Icon
Sewer56 Jun 13, 2024
cf8fd61
Removed Unused Icon and Fixed Icon Sizes via SVG Import
Sewer56 Jun 13, 2024
3c575ee
Removed: Legacy Diagnostics Icon and Fixed Design Icon for Left Menu
Sewer56 Jun 13, 2024
5449f96
Diff View: Center the 'State' Column Text
Sewer56 Jun 13, 2024
ebd85ae
Changed: Reorder Tree Data Grid Default Columns to Match Design
Sewer56 Jun 13, 2024
434d2aa
Changed: Advanced Installer and TreeDataGrid Icon Sizes to Match Design
Sewer56 Jun 13, 2024
6a89574
Changed: File icon to outline
Sewer56 Jun 13, 2024
b3b7dc4
Fixed: Incorrect Link on Progress-Download Icon
Sewer56 Jun 13, 2024
3e2bafd
Left Menu Icons now Styled via Styles; and Correct Size Too
Sewer56 Jun 13, 2024
3adc5b4
Replaced: Remaining Icons with Figma Accurate Sizes
Sewer56 Jun 13, 2024
47645ef
Improve: Panel Tab Header Matches Left Menu and Toolbar Icon Size
Sewer56 Jun 13, 2024
4b06adc
Merge remote-tracking branch 'erri120/main' into fixup-icons
Sewer56 Jun 13, 2024
04f2cbc
Added: Instructions for Correct SVG Import
Sewer56 Jun 13, 2024
7591cc9
Added: Missing Character in Link
Sewer56 Jun 13, 2024
83e0b42
Merge remote-tracking branch 'origin/main' into fixup-icons
Sewer56 Jun 20, 2024
0f135be
Removed: Shrink of Side Icon Per Design
Sewer56 Jun 20, 2024
98ec4d8
Fixed: Inconsistent Icon Size in Panel Header
Sewer56 Jun 20, 2024
f78f648
Removed: Scaling of Remaining Buttons Per Al Per Design
Sewer56 Jun 20, 2024
481ac94
Added: Minimal Width for Enabled Column in LoadoutGrid
Sewer56 Jun 20, 2024
f2b243e
Fixed: Tab Text is now Center Aligned
Sewer56 Jun 20, 2024
d182293
Changed: Tab Icons are now Size 20 to Match Remaining in-App Icons
Sewer56 Jun 20, 2024
c55a27b
Fixed: Vertical Alignment on Toolbar Items, ComboBox and Disabled Sty…
Sewer56 Jun 20, 2024
17d3e90
Removed: Redundant Size override on GameWidget
Sewer56 Jun 20, 2024
85ab108
Merge remote-tracking branch 'erri120/main' into fixup-icons
Sewer56 Jun 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
<Grid ColumnDefinitions="*, Auto" Margin="0,5,0,5">
<Grid.Styles>
<Style Selector="icons|UnifiedIcon.FileTypeIcon">
<Setter Property="Size" Value="18" />
<Setter Property="Margin" Value="8, 0, 0, 0" />
</Style>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,9 @@
<Grid ColumnDefinitions="*, Auto" Margin="0,5,0,5">
<Grid.Styles>
<Style Selector="icons|UnifiedIcon.FileTypeIcon">
<Setter Property="Size" Value="18" />
<Setter Property="Margin" Value="8, 0, 0, 0" />
</Style>

<Style Selector="icons|UnifiedIcon.Close">
<Setter Property="Size" Value="20" />
</Style>

<Style Selector="Button.RightElements">
<Setter Property="Margin" Value="0,0,8,0" />
</Style>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<Grid ColumnDefinitions="*, Auto" Margin="0,5,0,5">
<Grid.Styles>
<Style Selector="icons|UnifiedIcon.FileTypeIcon">
<Setter Property="Size" Value="18" />
<Setter Property="Margin" Value="8, 0, 8, 0" />
</Style>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<Grid ColumnDefinitions="Auto, *, Auto">
<Grid.Styles>
<Style Selector="icons|UnifiedIcon.FileTypeIcon">
<Setter Property="Size" Value="18" />
<Setter Property="Margin" Value="8, 0, 8, 0" />
</Style>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<Grid ColumnDefinitions="*, Auto" Margin="0,5,0,5">
<Grid.Styles>
<Style Selector="icons|UnifiedIcon.FileTypeIcon">
<Setter Property="Size" Value="18" />
<Setter Property="Margin" Value="8, 0, 8, 0" />
</Style>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@
<Design.DataContext>
<ui:GuidedInstallerOptionDesignViewModel />
</Design.DataContext>

<reactiveUi:ReactiveUserControl.Styles>
<!-- Match Icon Size with Design -->
<Style Selector="Border#SelectionHighlightBorder icons|UnifiedIcon">
<Setter Property="Size" Value="24" />
</Style>
</reactiveUi:ReactiveUserControl.Styles>

<Border x:Name="OptionContainerBorder" Classes="OptionBorder">
<Grid ColumnDefinitions="Auto, *" RowDefinitions="Auto">
Expand All @@ -24,7 +31,7 @@
<TextBlock Grid.Column="0" Classes="BodyMDNormal" x:Name="OptionNameTextBlock"
VerticalAlignment="Center" />
<icons:UnifiedIcon Classes="Image" IsVisible="False" Grid.Column="1" x:Name="ImageIcon"
VerticalAlignment="Center" />
VerticalAlignment="Center" />
<icons:UnifiedIcon Classes="Description" IsVisible="False" Grid.Column="2" x:Name="DescriptionIcon"
VerticalAlignment="Center" />
</Grid>
Expand Down
3 changes: 3 additions & 0 deletions src/NexusMods.App.UI/Assets/Icons/collections.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/NexusMods.App.UI/Assets/Icons/discord.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions src/NexusMods.App.UI/Assets/Icons/forum.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/NexusMods.App.UI/Assets/Icons/list_filled_24px.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/NexusMods.App.UI/Assets/Icons/mod_library.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/NexusMods.App.UI/Assets/Icons/mods.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/NexusMods.App.UI/Assets/Icons/stethoscope_24px.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 6 additions & 1 deletion src/NexusMods.App.UI/Controls/DataGrid/Helpers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ private static void GenerateColumnsImpl<TColumnType>(Avalonia.Controls.DataGrid
foreach (var column in columns)
{
var generatedColumn = column.Generate();
generatedColumn.Header = GenerateHeader(column.Type);
var header = GenerateHeader(column.Type);
generatedColumn.Header = header;
generatedColumn.MinWidth = header.MinWidth;
target.Columns.Add(generatedColumn);
}
}
Expand All @@ -42,6 +44,9 @@ private static Control GenerateHeader<TColumnType>(this TColumnType column) wher
LoadoutColumn.Category => new TextBlock { Text = Language.Helpers_GenerateHeader_CATEGORY },
LoadoutColumn.Installed => new TextBlock { Text = Language.Helpers_GenerateHeader_INSTALLED },
LoadoutColumn.Enabled => new ModEnabledHeader()
{
MinWidth = 65,
}
},
DownloadColumn downloadColumn => downloadColumn switch
{
Expand Down
4 changes: 2 additions & 2 deletions src/NexusMods.App.UI/Controls/GameWidget/GameWidget.axaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
IsVisible="False">
<Button Classes="Rounded Primary" x:Name="AddGameButton">
<StackPanel Orientation="Horizontal">
<icons:UnifiedIcon Size="20" Classes="Add" />
<icons:UnifiedIcon Classes="Add" />
<TextBlock Classes="BodyMDNormal"
Text="{x:Static resources:Language.GameWidget__Add_game}"/>
</StackPanel>
Expand Down Expand Up @@ -101,7 +101,7 @@
HorizontalAlignment="Stretch"
Grid.Column="0">
<StackPanel Orientation="Horizontal">
<icons:UnifiedIcon Size="20" Classes="Check" />
<icons:UnifiedIcon Classes="Check" />
<TextBlock Classes="BodyMDNormal"
Text="{x:Static resources:Language.GameWidget__View}"/>
</StackPanel>
Expand Down
6 changes: 3 additions & 3 deletions src/NexusMods.App.UI/Controls/TopBar/TopBarView.axaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@
<TextBlock Text="{x:Static resources:Language.TopBar_Help_ToolTip}" />
</ToolTip.Tip>
<MenuItem.Header>
<StackPanel Orientation="Horizontal" Spacing="0" Margin="10">
<icons:UnifiedIcon Classes="Help" Size="20" />
<icons:UnifiedIcon Classes="MenuDown" Size="24"/>
<StackPanel Orientation="Horizontal" Spacing="0" Margin="10, 0 , 10, 0">
<icons:UnifiedIcon Classes="Help"/>
<icons:UnifiedIcon Classes="MenuDown"/>
</StackPanel>
</MenuItem.Header>

Expand Down
4 changes: 2 additions & 2 deletions src/NexusMods.App.UI/Controls/Trees/DiffTreeViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,9 @@ internal static HierarchicalTreeDataGridSource<IFileTreeNodeViewModel> CreateTre
Columns =
{
FileTreeNodeViewModel.CreateTreeSourceNameColumn(),
FileTreeNodeViewModel.CreateTreeSourceStateColumn(),
FileTreeNodeViewModel.CreateTreeSourceFileCountColumn(),
FileTreeNodeViewModel.CreateTreeSourceSizeColumn(),
FileTreeNodeViewModel.CreateTreeSourceFileCountColumn(),
FileTreeNodeViewModel.CreateTreeSourceStateColumn(),
},
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/NexusMods.App.UI/Controls/Trees/FileTreeView.axaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<files:FileTreeNodeView DataContext="{CompiledBinding}" />
</DataTemplate>
<DataTemplate x:Key="FileStateColumnTemplate" DataType="{x:Type files:IFileTreeNodeViewModel}">
<TextBlock Text="{CompiledBinding FormattedChangeState}" >
<TextBlock Text="{CompiledBinding FormattedChangeState}" VerticalAlignment="Center" >
<ToolTip.Tip>
<TextBlock Text="{CompiledBinding FormattedChangeStateToolTip}" />
</ToolTip.Tip>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<Grid ColumnDefinitions="*, Auto" Margin="0,5,0,5">
<Grid.Styles>
<Style Selector="icons|UnifiedIcon.FileTypeIcon">
<Setter Property="Size" Value="18" />
<Setter Property="Margin" Value="8, 0, 0, 0" />
</Style>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ internal static HierarchicalTreeDataGridSource<IFileTreeNodeViewModel> CreateTre
Columns =
{
FileTreeNodeViewModel.CreateTreeSourceNameColumn(),
FileTreeNodeViewModel.CreateTreeSourceFileCountColumn(),
FileTreeNodeViewModel.CreateTreeSourceSizeColumn(),
FileTreeNodeViewModel.CreateTreeSourceFileCountColumn(),
},
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public HomeLeftMenuViewModel(
new IconViewModel
{
Name = Language.MyGames,
Icon = IconValues.JoystickGameFilled,
Icon = IconValues.Game,
NavigateCommand = ReactiveCommand.Create<NavigationInformation>(info =>
{
var pageData = new PageData
Expand Down
2 changes: 1 addition & 1 deletion src/NexusMods.App.UI/LeftMenu/Items/IconView.axaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
Height="36"
Padding="8,0,8,0">
<Grid ColumnDefinitions="Auto, *, Auto">
<icons:UnifiedIcon Grid.Column="0" Size="16" x:Name="LeftIcon" />
<icons:UnifiedIcon Grid.Column="0" x:Name="LeftIcon" />
<TextBlock
Margin="8 0 0 0"
Grid.Column="1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public LoadoutLeftMenuDesignViewModel()
new IconViewModel
{
Name = "Diagnostics",
Icon = IconValues.MonitorDiagnostics,
Icon = IconValues.Stethoscope,
},
]
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public DiagnosticDetailsViewModel(
IMarkdownRendererViewModel markdownRendererViewModel,
Diagnostic diagnostic) : base(windowManager)
{
TabIcon = IconValues.DiagnosticPage;
TabIcon = IconValues.Stethoscope;
TabTitle = diagnostic.Title;
Severity = diagnostic.Severity;

Expand Down
6 changes: 3 additions & 3 deletions src/NexusMods.App.UI/Pages/LoadoutGrid/LoadoutGridView.axaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<reactiveUi:ReactiveUserControl
<reactiveUi:ReactiveUserControl
d:DesignHeight="450"
d:DesignWidth="800"
mc:Ignorable="d"
Expand Down Expand Up @@ -30,8 +30,8 @@
</navigation:NavigationControl>
<Button x:Name="DeleteModsButton">
<StackPanel>
<icons:UnifiedIcon Classes="Close" />
<TextBlock Text="{x:Static resources:Language.LoadoutGridView__Remove}" />
<icons:UnifiedIcon Classes="PlaylistRemove" />
<TextBlock Text="{x:Static resources:Language.LoadoutGridView__Remove}"/>
</StackPanel>
</Button>
</StackPanel>
Expand Down
Loading
Loading