Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopBar rework #1580

Merged
merged 15 commits into from
Jun 11, 2024
Merged

TopBar rework #1580

merged 15 commits into from
Jun 11, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jun 11, 2024 •
edited
Loading

This ended up being larger than I'd like, but I wanted to rework the top bar in one PR. Changes:

  • Add User ID in UserInfo
  • Add IOSInterop.OpenFile and IOSInterop.OpenDirectory which are currently just stubs
  • Added styles for MenuItem, going forward we just use Menu and MenuItem for all toolbars
  • Added NavigationMenuItem as a counterpart to NavigationControl. This control will be updated later to make it more distinct, once we have sub-menu item.

TODOs for future PRs:

  • Implement the IOSInterop stubs
  • Rework the add-panel button and convert it into a MenuItem

Issues:

@erri120 erri120 requested a review from a team June 11, 2024 10:30
@erri120 erri120 self-assigned this Jun 11, 2024
@Al12rs Al12rs merged commit c31abbc into Nexus-Mods:main Jun 11, 2024
5 checks passed
@erri120 erri120 deleted the feat/1552-toolbar-profile branch June 11, 2024 12:09
@erri120 erri120 mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al12rs Al12rs Al12rs approved these changes

Assignees

@erri120 erri120

Labels
None yet
Projects
MVP
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topbar Help button design improvement User profile button and logout design improvement
2 participants
@erri120 @Al12rs