-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Bring Window to Foreground on Login #1544
Conversation
@Al12rs can you test this on Windows? I can't test this on Linux. |
I already tested this on Windows and with the fix on the name it does work. |
Co-authored-by: Al <[email protected]>
I got the feedback sorted, hopefully should be good now. Extra Note: I tested this on both Linux and Windows. Though on Linux I normally use a tiling WM so my window is already topmost, so I had to install an alternative Window Manager to test this. I only initially brought it to focus if it wasn't minimized, because it's what the ticket requested. In a normal UX flow, the user opens the browser from the App, and the App fills the screen. I did make it unminimize the window now though. |
This is a basic implementation for:
Although this PR is fairly simple, and adheres to UI Guidelines... it feels, weird. For some reason I don't feel good about it.
If you have any better ideas for implementing this, please let me know.
I could integrate this sort of functionality into the workspace system, and persist the window that started the login request in a global location so the correct one is brought to front. However, I've decided to keep things as simple as possible for now. Let me know how far you want me to go with this.