feat(cloudformation): Add env var for default CFN role ARN #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaikaN57
commented
Jan 13, 2025
Comment on lines
+554
to
+555
| elif KINGPIN_CFN_DEFAULT_ROLE_ARN: | ||
| cfg["RoleARN"] = KINGPIN_CFN_DEFAULT_ROLE_ARN |
There was a problem hiding this comment.
This is the only "real" change in this PR. There is one other place we do this setting and there is an entry in the aws settings file to support this as an env var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mainly
KINGPIN_CFN_DEFAULT_ROLESupplimetry
Motivation
We wanted give our build roles tight privledges on only interact directly with the AWS API for things that
kingpincan manage directly (ie. s3, iam, cfn). However, we want to pass another role to the CFN service to use to create all kinds of resources thatkingpindoes not natively manage.